Cleanup in atexit #3184
Closed
Cleanup in atexit #3184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change modifies the
atexit_cleanupfunction in the codebase to ensure reliable cleanup behavior upon Python process exit. It introduces a new implementation while maintaining the same output as the original function.Changed Behaviour
After this change, the
atexit_cleanupfunction will still log messages indicating whether cleanup is performed due to the Python process exiting or if cleanup has already been completed. However, the implementation of the function is updated to ensure robustness and handle exceptions during cleanup more effectively.Fixes
Fixes # (3165)
Type of change
Choose which options apply, and delete the ones which do not apply.