Upadate SimpleLauncher class to warn user #3180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s not an advanced user tries use more than 1 node per block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and (optionally) which issue is fixed. Please also include
relevant motivation and context.
Updated the SimpleLauncher class to throw a warning when a user tries to use more than one node per block. Advanced users do not get a warning if they set permit_multiple_nodes=True. This PR fixes issue #3161
Changed Behaviour
Which existing user workflows or functionality will behave differently after this PR?
Users who are not advanced users will now get a warning when they try to use more than one node per block. Advanced users will not get a warning if they set permit_multiple_nodes=True.
Fixes
Fixes # (issue)
#3161
Type of change
Choose which options apply, and delete the ones which do not apply.