Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected Type Error on process_worker_pool.py #3175

Closed
wants to merge 1 commit into from

Conversation

christailu
Copy link
Contributor

Description

This PR enhances argument handling in the process_worker_pool.py script by making the --available-accelerators parameter optional with a default value. Additionally, it adds validation for the --cpu-affinity parameter and ensures that the MPI launcher is provided when MPI mode is enabled.

Changed Behaviour

After this PR, users can run the process_worker_pool.py script without providing the --available-accelerators argument. If not provided, it defaults to an empty list, indicating zero accelerators available. Furthermore, the script now validates the --cpu-affinity parameter to ensure it contains a valid value, and it enforces the requirement of providing the MPI launcher when MPI mode is enabled.

Fixes

Fixes # (issue)

Type of change

Choose which options apply, and delete the ones which do not apply.

  • Bug fix

@christailu
Copy link
Contributor Author

Hello @benclifford , can you take a look at what I have made and please give me some feedback on what I can improve thanks!

@christailu christailu closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant