Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate monitoring core and visualization dependencies #2911

Merged
merged 5 commits into from
Oct 21, 2023

Conversation

benclifford
Copy link
Collaborator

@benclifford benclifford commented Oct 14, 2023

This reflects a difference in code maturity and maintenance between the two: monitoring core is much more maintained and stable than visualization at the moment.

Work with LSST has repeatedly encountered dependency problems caused by the visualization dependencies, even though those dependencies are not need by LSST, and this separation allows the visualization dependencies to be skipped.

Breaking change:
If you are using visualization you will now need to:

pip install parsl[monitoring,visualization]

to get all of the dependencies previously installed by [monitoring]

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code maintentance/cleanup

This reflects a difference in code maturity and maintenance between the
two: monitoring core is much more maintained and stable than visualization
at the moment.

Work with LSST has repeatedly encountered dependency problems caused by
the visualization dependencies, even though those dependencies are not need
by LSST, and this separation allows the visualization dependencies to be
skipped.

Breaking change:
If you are using visualization you will now need to:

  pip install parsl[monitoring,visualization]

to get all of the dependencies previously installed by [monitoring]
@Andrew-S-Rosen
Copy link
Contributor

Thank you for this. It will be a big help, as I've run into some annoying version conflicts with the visualization dependencies even if I just wanted to use monitoring features.

@Andrew-S-Rosen
Copy link
Contributor

A small suggestion: it would probably be worth updating the docs too, e.g. for the monitoring page to highlight this new install procedure.

@benclifford benclifford merged commit 8437778 into master Oct 21, 2023
4 checks passed
@benclifford benclifford deleted the benc-desc-viz-dependencies branch October 21, 2023 21:21
benclifford added a commit that referenced this pull request Feb 7, 2024
This is masked on master because of test execution order, but breaks on desc
branch at the moment because of re-ordered tests

This broke in PR #2911 which split montoring dependencies into two in
setup.py
benclifford added a commit that referenced this pull request Feb 8, 2024
This is masked on master because of test execution order, but breaks on desc
branch at the moment because of re-ordered tests

This broke in PR #2911 which split montoring dependencies into two in
setup.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants