Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make parsl-perf iterations have at least 1 task #2896

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Conversation

benclifford
Copy link
Collaborator

Prior to this PR: In some startup situations, the estimated number of tasks for the next iteration can round down to 0, and then parsl-perf can sometimes enter an infinite loop without increasing the loop size:

==== Iteration 29463 ====
Will run 0 tasks to target 20.0 seconds runtime
Submitting tasks / invoking apps
All 0 tasks submitted ... waiting for completion
Submission took 2.1457672119140625e-06 seconds = 0.0 tasks/second Runtime: 1.049041748046875e-05s vs target 20.0
Tasks per second: 0.0

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Prior to this PR: In some startup situations, the estimated number of
tasks for the next iteration can round down to 0, and then parsl-perf
can sometimes enter an infinite loop without increasing the loop size:

==== Iteration 29463 ====
Will run 0 tasks to target 20.0 seconds runtime
Submitting tasks / invoking apps
All 0 tasks submitted ... waiting for completion
Submission took 2.1457672119140625e-06 seconds = 0.0 tasks/second
Runtime: 1.049041748046875e-05s vs target 20.0
Tasks per second: 0.0
Copy link
Collaborator

@khk-globus khk-globus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks on target. But CI doesn't like something ... (of course!)

@benclifford benclifford merged commit f8fb612 into master Oct 3, 2023
4 checks passed
@benclifford benclifford deleted the benc-perf-min branch October 3, 2023 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants