Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bash_app keyword arg defaults are overwritten when a bash_app is called multiple times #1058

Closed
benclifford opened this issue Jun 12, 2019 · 1 comment
Labels
Milestone

Comments

@benclifford
Copy link
Collaborator

benclifford commented Jun 12, 2019

given

@bash_app
def f(z=2):
return "echo {z}"

then the app call sequence:

f()
f(z=3)
f(z=4)
f()

will output 2,3,4,4, when it should output 2,3,4,2

I think this comes from the use of a kwargs structure that is scoped to the definition of the f app and mutated on every invocation, in parsl/app/bash.py

This branch adds a more fleshed out test case:
https://github.com/Parsl/parsl/tree/benc-1058-bash-app-kwarg-defaults

@yadudoc yadudoc added the bug label Jun 19, 2019
@yadudoc yadudoc added this to the Parsl-0.9.0 milestone Jun 19, 2019
benclifford added a commit that referenced this issue Jul 1, 2019
This will become the regression test for #1058 when it is fixed.
@yadudoc yadudoc modified the milestones: Parsl-0.9.0, Parsl-0.10.0 Oct 25, 2019
benclifford added a commit that referenced this issue Oct 29, 2019
The xfailing test for this needed updating a bit to reflect
recent changes in parsl.

Fixes issue #1058
yadudoc pushed a commit that referenced this issue Oct 30, 2019
…#1413)

The xfailing test for this needed updating a bit to reflect
recent changes in parsl.

Fixes issue #1058
@benclifford
Copy link
Collaborator Author

fixed by #1413

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants