Skip to content

Commit

Permalink
Remove monitoring UDP hub_port from example/test configs
Browse files Browse the repository at this point in the history
This port will be chosen dynamically, and that is fine in test situations.

Ongoing work to refactor monitoring radios will remove this hub_port
parameter, making it either unnecessary (when non-UDP monitoring radios are
used) or specified as part of the radio selection.

This PR removes hub_port from tests and examples as preparation for that
change.
  • Loading branch information
benclifford committed Nov 29, 2024
1 parent 7c2646e commit b42ada2
Show file tree
Hide file tree
Showing 7 changed files with 0 additions and 7 deletions.
1 change: 0 additions & 1 deletion docs/userguide/monitoring.rst
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ configuration. Here the `parsl.monitoring.MonitoringHub` is specified to use por
],
monitoring=MonitoringHub(
hub_address=address_by_hostname(),
hub_port=55055,
monitoring_debug=False,
resource_monitoring_interval=10,
),
Expand Down
1 change: 0 additions & 1 deletion parsl/configs/ASPIRE1.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
],
monitoring=MonitoringHub(
hub_address=address_by_interface('ib0'),
hub_port=55055,
resource_monitoring_interval=10,
),
strategy='simple',
Expand Down
1 change: 0 additions & 1 deletion parsl/tests/configs/htex_local_alternate.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ def fresh_config():
retries=2,
monitoring=MonitoringHub(
hub_address="localhost",
hub_port=55055,
monitoring_debug=False,
resource_monitoring_interval=1,
),
Expand Down
1 change: 0 additions & 1 deletion parsl/tests/configs/local_threads_monitoring.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
config = Config(executors=[ThreadPoolExecutor(label='threads', max_threads=4)],
monitoring=MonitoringHub(
hub_address="localhost",
hub_port=55055,
resource_monitoring_interval=3,
)
)
1 change: 0 additions & 1 deletion parsl/tests/manual_tests/test_udp_simple.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ def local_setup():
],
monitoring=MonitoringHub(
hub_address="127.0.0.1",
hub_port=55055,
logging_level=logging.INFO,
resource_monitoring_interval=10))

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ def fresh_config(run_dir, strategy, db_url):
strategy_period=0.1,
monitoring=MonitoringHub(
hub_address="localhost",
hub_port=55055,
logging_endpoint=db_url
)
)
Expand Down
1 change: 0 additions & 1 deletion parsl/tests/test_monitoring/test_stdouterr.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ def fresh_config(run_dir):
strategy_period=0.1,
monitoring=MonitoringHub(
hub_address="localhost",
hub_port=55055,
)
)

Expand Down

0 comments on commit b42ada2

Please sign in to comment.