Skip to content

Commit

Permalink
Worker does not need a remote logdir any more - it is always local, a…
Browse files Browse the repository at this point in the history
…nd per-component logdir configurability should not be a Parsl feature - if this is something people really want, we should push on providing user-configurable logging in the worker
  • Loading branch information
benclifford committed Nov 1, 2024
1 parent 8c46bc6 commit 8bdc8cf
Showing 1 changed file with 1 addition and 12 deletions.
13 changes: 1 addition & 12 deletions parsl/executors/high_throughput/executor.py
Original file line number Diff line number Diff line change
Expand Up @@ -140,9 +140,6 @@
period for the batch job to start the workers, minus the expected
maximum length of an individual task.
worker_logdir_root : string
In case of a remote file system, specify the path to where logs will be kept.
encrypted : bool
Flag to enable/disable encryption (CurveZMQ). Default is False.
Expand Down Expand Up @@ -250,7 +247,6 @@ def __init__(self,
drain_period: Optional[int] = None,
poll_period: int = 10,
address_probe_timeout: Optional[int] = None,
worker_logdir_root: Optional[str] = None,
manager_selector: ManagerSelector = RandomManagerSelector(),
block_error_handler: Union[bool, Callable[[BlockProviderExecutor, Dict[str, JobStatus]], None]] = True,
encrypted: bool = False):
Expand Down Expand Up @@ -309,7 +305,6 @@ def __init__(self,
self.drain_period = drain_period
self.poll_period = poll_period
self.run_dir = '.'
self.worker_logdir_root = worker_logdir_root
self.cpu_affinity = cpu_affinity
self.encrypted = encrypted
self.cert_dir = None
Expand Down Expand Up @@ -338,12 +333,6 @@ def _warn_deprecated(self, old: str, new: str):
def logdir(self):
return "{}/{}".format(self.run_dir, self.label)

@property
def worker_logdir(self):
if self.worker_logdir_root is not None:
return "{}/{}".format(self.worker_logdir_root, self.label)
return self.logdir

def validate_resource_spec(self, resource_specification: dict):
"""HTEX supports the following *Optional* resource specifications:
priority: lower value is higher priority"""
Expand Down Expand Up @@ -384,7 +373,7 @@ def initialize_scaling(self):
drain_period=self.drain_period,
poll_period=self.poll_period,
cert_dir=self.cert_dir,
logdir=self.worker_logdir,
logdir=self.logdir,
cpu_affinity=self.cpu_affinity,
enable_mpi_mode=enable_mpi_opts,
mpi_launcher=self.mpi_launcher,
Expand Down

0 comments on commit 8bdc8cf

Please sign in to comment.