Make router_starter parameters mandatory kwargs (#3583)

See PR #2973 for justification of mandatory keyword args.
Parsl · Aug 16, 2024 · 357547f · 357547f
1 parent e34a70a
commit 357547f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/parsl/monitoring/monitoring.py b/parsl/monitoring/monitoring.py
@@ -154,9 +154,14 @@ def start(self, dfk_run_dir: str, config_run_dir: Union[str, os.PathLike]) -> No
         self.router_exit_event = Event()
 
         self.router_proc = ForkProcess(target=router_starter,
-                                       args=(comm_q, self.exception_q, self.priority_msgs, self.node_msgs,
-                                             self.block_msgs, self.resource_msgs, self.router_exit_event),
-                                       kwargs={"hub_address": self.hub_address,
+                                       kwargs={"comm_q": comm_q,
+                                               "exception_q": self.exception_q,
+                                               "priority_msgs": self.priority_msgs,
+                                               "node_msgs": self.node_msgs,
+                                               "block_msgs": self.block_msgs,
+                                               "resource_msgs": self.resource_msgs,
+                                               "exit_event": self.router_exit_event,
+                                               "hub_address": self.hub_address,
                                                "udp_port": self.hub_port,
                                                "zmq_port_range": self.hub_port_range,
                                                "logdir": self.logdir,

diff --git a/parsl/monitoring/router.py b/parsl/monitoring/router.py
@@ -204,7 +204,8 @@ def start_zmq_listener(self) -> None:
 
 @wrap_with_logs
 @typeguard.typechecked
-def router_starter(comm_q: mpq.Queue,
+def router_starter(*,
+                   comm_q: mpq.Queue,
                    exception_q: mpq.Queue,
                    priority_msgs: mpq.Queue,
                    node_msgs: mpq.Queue,