Release 3.1.0 #608

pauarge · 2022-01-20T11:23:38Z

This branch pulls all the changes from develop and puts them into trunk. We are including the CHANGELOG and version bumps alongside.

Second argument supported since PHP 7.0.

Makes them all explicitly `public`, but some of these could be made less visible. See #428.

More performant than single character alternation.

* Tests: Stop using deprecated setMethods method Use `onlyMethods()` instead, which ensures that the method that is being mocked does exist in the class being mocked. * Tests: use onlyMethods() only if it exists

* Displaying Open on Parse.ly links by default * Empty

* Remove deprecated filter after_set_parsely_page * Updating tests

* Remove deprecated filter parsely_filter_insert_javascript * Removing deprecated test

* Fixing code smells * Removing duplicate * Fix linting issues

* Adding E2E test to check for available recommended widget * Adding utils * Documenting utils and separating logical behavior * Adding missing await * Extracting more logic into constants

…warnings downstream (#438) * Update class-parsely.php Change default from null to empty array to prevent warnings thrown by array_diff on line 1650 * Update src/class-parsely.php Co-authored-by: Pau Argelaguet <[email protected]> Co-authored-by: Pau Argelaguet <[email protected]>

* Add wp_parsely_should_insert_metadata filter * Revert return change * Update src/class-parsely.php Co-authored-by: Gary Jones <[email protected]> Co-authored-by: Gary Jones <[email protected]>

* Adding uninstall script * Addressing linting issues

Bumps [@wordpress/e2e-test-utils](https://github.com/WordPress/gutenberg/tree/HEAD/packages/e2e-test-utils) from 5.4.3 to 5.4.4. - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/e2e-test-utils/CHANGELOG.md) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/[email protected]/packages/e2e-test-utils) --- updated-dependencies: - dependency-name: "@wordpress/e2e-test-utils" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [@wordpress/scripts](https://github.com/WordPress/gutenberg/tree/HEAD/packages/scripts) from 18.0.1 to 18.1.0. - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/scripts/CHANGELOG.md) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/[email protected]/packages/scripts) --- updated-dependencies: - dependency-name: "@wordpress/scripts" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Constant return type on insert_parsely_page * Adding deprecation warning for method * Fix linting issues * Fixing backwards compat return * Update src/class-parsely.php Co-authored-by: Gary Jones <[email protected]> Co-authored-by: Gary Jones <[email protected]>

* Fixing return types of update_metadata_endpoint * Fix identation

* Change to non-post default * Fix linting issues * Adding docstring to document parameter change

* Fix type errors when generating metadata -- backport from VIP * Yoda conditionals to appease the linter Co-authored-by: Pau Argelaguet <[email protected]>

CHANGELOG.md

CONTRIBUTING.md

README.md

CHANGELOG.md

Co-authored-by: Jeff Bowen <[email protected]>

Co-authored-by: Gary Jones <[email protected]>

CHANGELOG.md

CONTRIBUTING.md

acicovic · 2022-01-21T07:49:15Z

CONTRIBUTING.md

+
+To release a new version of the plugin, a GitHub issue with the name of the release (for instance, _Release 3.2.1_) has to be created using the _Release_ template.
+
+After creating the issue, all the steps laid down in that template must be completed in order. Every time a step is completed, please mark it using the checkbox. Once all steps are done, the issue can be closed. 


all the steps laid down in that template must be completed in order

Is this really the case?

README.md

pauarge · 2022-01-21T08:04:04Z

Hi @acicovic, I agree with most of your changes on the CONTRIBUTING file. They got included in #567 and #525. Since they are minor changes, I suggest we go ahead with the release and we address them in a separate PR.

GaryJones and others added 30 commits October 1, 2021 15:13

Nested dirname calls can be replaced

0d6d521

Second argument supported since PHP 7.0.

Declare visibility for class-level constants

bf0e20b

Makes them all explicitly `public`, but some of these could be made less visible. See #428.

Convert documented param type to short form

7db2069

Fix discrepancy of class name and its use

f5984d6

Replace full qualified name with an import

94931b3

Inline one-time use variables

289b9f6

Add return type declarations

c770a3e

Remove incorrect return type declaration

74b55ba

Fix typos and unnecessary abbreviations

677d2cd

Remove unnecessary regular expression escaping

f5159e1

Regexp: Use character class

580ffa2

More performant than single character alternation.

Use const syntax instead of define()

1634cab

Fix CS alignments

c8be344

Merge pull request #431 from Parsely/feature/minor-code-fixes

3e5e9b2

Tests: Stop using deprecated setMethods method (#427)

bb6d44b

* Tests: Stop using deprecated setMethods method Use `onlyMethods()` instead, which ensures that the method that is being mocked does exist in the class being mocked. * Tests: use onlyMethods() only if it exists

Displaying Open on Parse.ly links by default (#433)

1c02564

* Displaying Open on Parse.ly links by default * Empty

Remove deprecated filter after_set_parsely_page (#436)

986f792

* Remove deprecated filter after_set_parsely_page * Updating tests

Remove deprecated filter parsely_filter_insert_javascript (#437)

67378b7

* Remove deprecated filter parsely_filter_insert_javascript * Removing deprecated test

Fixing some code smells (#435)

34e4ccb

* Fixing code smells * Removing duplicate * Fix linting issues

Adding E2E test to check for available recommended widget (#434)

ff9d8a9

* Adding E2E test to check for available recommended widget * Adding utils * Documenting utils and separating logical behavior * Adding missing await * Extracting more logic into constants

Fix not working readme code sample (#439)

66f00ec

Removing old init script (#441)

4fcaa2a

Add wp_parsely_should_insert_metadata filter (#440)

9c2a578

* Add wp_parsely_should_insert_metadata filter * Revert return change * Update src/class-parsely.php Co-authored-by: Gary Jones <[email protected]> Co-authored-by: Gary Jones <[email protected]>

Adding uninstall script (#444)

5dd3514

* Adding uninstall script * Addressing linting issues

Fixing return types of update_metadata_endpoint (#446)

d93f7b6

* Fixing return types of update_metadata_endpoint * Fix identation

Change get_current_url default type to non-post (#447)

acfce95

* Change to non-post default * Fix linting issues * Adding docstring to document parameter change

jblz and others added 3 commits January 20, 2022 12:11

Backport TypeError Fixes from VIP (#607)

d45724d

* Fix type errors when generating metadata -- backport from VIP * Yoda conditionals to appease the linter Co-authored-by: Pau Argelaguet <[email protected]>

Merge branch 'trunk' into release-3.1.0

a1e258c

Adding CHANGELOG

bd3f77d

pauarge added this to the 3.1.0 milestone Jan 20, 2022

pauarge changed the base branch from develop to trunk January 20, 2022 11:24

pauarge added 2 commits January 20, 2022 12:25

Revert tabulation

16830af

Updating version number

1cd294d

pauarge marked this pull request as ready for review January 20, 2022 11:34

pauarge requested a review from a team as a code owner January 20, 2022 11:34

pauarge added 2 commits January 20, 2022 12:41

Revert changes on CHANGELOG.md

079ec94

Updating CHANGELOG link

585a183

jblz reviewed Jan 20, 2022

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

CONTRIBUTING.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

GaryJones reviewed Jan 20, 2022

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

pauarge and others added 4 commits January 20, 2022 15:08

Update CHANGELOG.md

d27ea7e

Co-authored-by: Jeff Bowen <[email protected]>

Update CONTRIBUTING.md

202fe98

Co-authored-by: Jeff Bowen <[email protected]>

Update README.md

ead7603

Co-authored-by: Jeff Bowen <[email protected]>

Update CHANGELOG.md

1645399

Co-authored-by: Gary Jones <[email protected]>

pauarge requested review from GaryJones and jblz January 20, 2022 14:08

acicovic reviewed Jan 21, 2022

View reviewed changes

CHANGELOG.md Show resolved Hide resolved

acicovic reviewed Jan 21, 2022

View reviewed changes

CONTRIBUTING.md Show resolved Hide resolved

acicovic reviewed Jan 21, 2022

View reviewed changes

CONTRIBUTING.md Show resolved Hide resolved

acicovic reviewed Jan 21, 2022

View reviewed changes

README.md Show resolved Hide resolved

acicovic approved these changes Jan 21, 2022

View reviewed changes

pauarge merged commit 1f28ab8 into trunk Jan 21, 2022

pauarge deleted the release-3.1.0 branch January 21, 2022 08:22

acicovic mentioned this pull request Jan 24, 2022

Update CONTRIBUTING.md for clarity and readability #613

Merged

pauarge mentioned this pull request Feb 21, 2022

Minor additions to the contributing file #683

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release 3.1.0 #608

Release 3.1.0 #608

pauarge commented Jan 20, 2022 •

edited

Loading

acicovic Jan 21, 2022 •

edited

Loading

pauarge commented Jan 21, 2022


		To release a new version of the plugin, a GitHub issue with the name of the release (for instance, _Release 3.2.1_) has to be created using the _Release_ template.

		After creating the issue, all the steps laid down in that template must be completed in order. Every time a step is completed, please mark it using the checkbox. Once all steps are done, the issue can be closed.

Release 3.1.0 #608

Release 3.1.0 #608

Conversation

pauarge commented Jan 20, 2022 • edited Loading

acicovic Jan 21, 2022 • edited Loading

Choose a reason for hiding this comment

pauarge commented Jan 21, 2022

pauarge commented Jan 20, 2022 •

edited

Loading

acicovic Jan 21, 2022 •

edited

Loading