Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy on published release #508

Merged
merged 255 commits into from
Nov 25, 2021
Merged

Deploy on published release #508

merged 255 commits into from
Nov 25, 2021

Conversation

GaryJones
Copy link
Contributor

As per https://docs.github.com/en/actions/learn-github-actions/events-that-trigger-workflows#release, the workflow will only fire when we publish a release on GitHub. The released type will only fire for stable releases, and not pre-release releases.

This allows tagging and release of alpha and beta versions, without it automatically pushing to WPORG SVN which then result in sites pulling those in via plugin auto-updates.

mikeyarce and others added 30 commits June 2, 2021 15:19
@mikeyarce
Add unit test for CPT term archive
16da907
@mikeyarce
Beautify code
9491924
@mikeyarce
Remove custom post type to simplify test
bd3f349 
It doesn’t change the functionality to have a custom post type or not, so to simplify we’ll remove that from the test.
@mikeyarce
Change cpt-tax-archive to cpt-archive
baa64ad
@mikeyarce
Fix code comments
7371d01
@mikeyarce
Clarify the name of the custom taxonomy
8db6730
@mikeyarce
Update check for cpt and taxonomy archives
d626f75
@mikeyarce
Change test name
cb9b3fa
@jblz
functioning e2e framework
786497b
@jblz
hello world test
5fa99f0
@jblz
package-lock (+@wordpress/e2e-test-utils)
d8b6144
@jblz
hook tests into CI
d06de5e
@jblz
limit to a single job
de501dc
@jblz
Update npm to latest
03771c7
@jblz
cache npm in setup-node
8d59c52
@jblz
switch to lts syntax for node-version
5a90768
@jblz
some progress using docker compose
7020095
@jblz
more progress -- it's working!
e691d86
@jblz
docker-compose vs docker compose
c11bc0f
@jblz
trying to wait for wp
8a75e6a
@jblz
working loop i hope
d896db5
@jblz
bg docker-compose correctly
583e0f7
@jblz
tweak name & rm unused var
5a56358
@jblz
rm the strategy and just code in node lts
9c0528c
@jblz
try npm ci
341deff
@jblz
README for e2e tests
979bafc
@jblz
fixup watch runner name
d9709fb
@jblz
add option to reset wp db to init script
85b96b1
@jblz
update readme
4574531
@jblz
update e2e readme
47f352f
pauarge and others added 22 commits November 2, 2021 11:22
@pauarge
Avoid making duplicate calls on Recommended Widget (#460)
f75dfa4 
* Avoid making duplicate calls on Recommended Widget

* Refactoring constructUrl

* Fixing parsing issues of updated values

* Adding e2e tests

* Adding type fixes

* Improving type fixes

* Revert optional post
@pauarge
Extract admin warning from class-parsely (#468)
6573cc3 
* Moving settings page out of class-parsely

* Move print dynamic tracking note

* Fixing hooks

* Fix automated linting issues

* Fix manual linting issues

* Extracting admin warning

* Updating hook to _admin_menu

* Moving admin warning tests

* Fix get method
@GaryJones @pauarge
e2e tests: fix watch command (#476)
9774d6e 
* e2e tests: fix watch command

Previously it would error as `test-e2e` command didn't exist.

* Update package.json

* Adding e2e interactive command

* Fix padding

Co-authored-by: Pau Argelaguet <[email protected]>
Co-authored-by: Pau Argelaguet <[email protected]>
@pauarge @GaryJones
Adding namespace to root class (#477)
26b3922 
* Starting namespace add

* Adding namespace to root class

* Working on tests

* Working on UI tests

* Address StructuredData tests

* Explicit WP_User import

* Fix linting issues

* Using fully qualified names on docstrings in StructuredData tests

* Correcting more docstrings

* Fixing warnings on UI tests

* Fix get_options

* Removing warnings on AdminWarningTest

* Fix FBIA tests

* Fix Integrations Test

* Update tests/Integration/Integrations/AmpTest.php

Co-authored-by: Gary Jones <[email protected]>

* Update tests/Integration/Integrations/AmpTest.php

Co-authored-by: Gary Jones <[email protected]>

* Update tests/Integration/Integrations/AmpTest.php

Co-authored-by: Gary Jones <[email protected]>

* Update tests/Integration/Integrations/AmpTest.php

Co-authored-by: Gary Jones <[email protected]>

* Update tests/Integration/Integrations/AmpTest.php

Co-authored-by: Gary Jones <[email protected]>

Co-authored-by: Gary Jones <[email protected]>
@dependabot
Bump @wordpress/scripts from 19.0.0 to 19.1.0 (#480)
9ce0853 
Bumps [@wordpress/scripts](https://github.com/WordPress/gutenberg/tree/HEAD/packages/scripts) from 19.0.0 to 19.1.0.
- [Release notes](https://github.com/WordPress/gutenberg/releases)
- [Changelog](https://github.com/WordPress/gutenberg/blob/@wordpress/[email protected]/packages/scripts/CHANGELOG.md)
- [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/[email protected]/packages/scripts)

---
updated-dependencies:
- dependency-name: "@wordpress/scripts"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @pauarge
Bump @wordpress/e2e-test-utils from 5.4.5 to 5.4.6 (#479)
3d01b2e 
Bumps [@wordpress/e2e-test-utils](https://github.com/WordPress/gutenberg/tree/HEAD/packages/e2e-test-utils) from 5.4.5 to 5.4.6.
- [Release notes](https://github.com/WordPress/gutenberg/releases)
- [Changelog](https://github.com/WordPress/gutenberg/blob/@wordpress/[email protected]/packages/e2e-test-utils/CHANGELOG.md)
- [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/[email protected]/packages/e2e-test-utils)

---
updated-dependencies:
- dependency-name: "@wordpress/e2e-test-utils"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Pau Argelaguet <[email protected]>
@dependabot
Bump @wordpress/e2e-test-utils from 5.4.6 to 5.4.7 (#488)
eaca690 
Bumps [@wordpress/e2e-test-utils](https://github.com/WordPress/gutenberg/tree/HEAD/packages/e2e-test-utils) from 5.4.6 to 5.4.7.
- [Release notes](https://github.com/WordPress/gutenberg/releases)
- [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/e2e-test-utils/CHANGELOG.md)
- [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/[email protected]/packages/e2e-test-utils)

---
updated-dependencies:
- dependency-name: "@wordpress/e2e-test-utils"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@pauarge
Use checkboxes for multiple selects in settings page (#482)
1a4bada 
* Moving settings page out of class-parsely

* Move print dynamic tracking note

* Fixing hooks

* Fix automated linting issues

* Fix manual linting issues

* Updating hook to _admin_menu

* Working on settings select

* Formatting data correctly

* Rollback new line

* Reverting label change

* Fix automated linting issues

* Fix linting issues

* Simplifying select

* Removing references to multiple argument

* Displaying public taxonomies only

* Matching id and label of checkbox
@pauarge
Move tracker logic to separate file (#478)
c8e9ae2 
* Starting namespace add

* Adding namespace to root class

* Working on tests

* Working on UI tests

* Address StructuredData tests

* Explicit WP_User import

* Fix linting issues

* Using fully qualified names on docstrings in StructuredData tests

* Correcting more docstrings

* Fixing warnings on UI tests

* Fix get_options

* Removing warnings on AdminWarningTest

* Fix FBIA tests

* Fix Integrations Test

* Splitting out tracker code

* Adding tracker test

* Adding additional tests

* Keep moving tests

* Moving constant

* Adding WP_Scripts

* Renaming class to scripts

* Fixing scripts naming

* Fix path

* Making sure script enqueue is clean

* Fix linting issues

* Updating comment

* Updating more comments
@dependabot
Bump @wordpress/eslint-plugin from 9.2.0 to 9.3.0 (#490)
5ffdd2a 
Bumps [@wordpress/eslint-plugin](https://github.com/WordPress/gutenberg/tree/HEAD/packages/eslint-plugin) from 9.2.0 to 9.3.0.
- [Release notes](https://github.com/WordPress/gutenberg/releases)
- [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/[email protected]/packages/eslint-plugin)

---
updated-dependencies:
- dependency-name: "@wordpress/eslint-plugin"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump @wordpress/e2e-test-utils from 5.4.7 to 5.4.8 (#492)
33f9310 
Bumps [@wordpress/e2e-test-utils](https://github.com/WordPress/gutenberg/tree/HEAD/packages/e2e-test-utils) from 5.4.7 to 5.4.8.
- [Release notes](https://github.com/WordPress/gutenberg/releases)
- [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/e2e-test-utils/CHANGELOG.md)
- [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/[email protected]/packages/e2e-test-utils)

---
updated-dependencies:
- dependency-name: "@wordpress/e2e-test-utils"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @pauarge
Bump @wordpress/scripts from 19.1.0 to 19.2.1 (#491)
6e4d4a1 
Bumps [@wordpress/scripts](https://github.com/WordPress/gutenberg/tree/HEAD/packages/scripts) from 19.1.0 to 19.2.1.
- [Release notes](https://github.com/WordPress/gutenberg/releases)
- [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/scripts/CHANGELOG.md)
- [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/[email protected]/packages/scripts)

---
updated-dependencies:
- dependency-name: "@wordpress/scripts"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Pau Argelaguet <[email protected]>
@pauarge
Renaming functions on Scripts class (#481)
226fc75 
* Starting namespace add

* Adding namespace to root class

* Working on tests

* Working on UI tests

* Address StructuredData tests

* Explicit WP_User import

* Fix linting issues

* Using fully qualified names on docstrings in StructuredData tests

* Correcting more docstrings

* Fixing warnings on UI tests

* Fix get_options

* Removing warnings on AdminWarningTest

* Fix FBIA tests

* Fix Integrations Test

* Splitting out tracker code

* Adding tracker test

* Adding additional tests

* Keep moving tests

* Moving constant

* Adding WP_Scripts

* Fixing small issues with scripts class

* Renaming class to scripts

* Fixing scripts naming

* Fix path

* Renaming functions on tests
@pauarge
Adding a cannonical way of running the plugin locally (#493)
c778984 
* Adding a local dev environment

* Adding link to VIP dev-env

* Fix tabs on package.json
@pauarge @GaryJones
Making class members private (#486)
0f0869c 
* Making class members private

* Fix FBIA tests

* Fix Recommended API tests

* Revert AMP changes

* Using reflection in tests

* Test with hardcoded constant

* Fix test

* Update tests/Integration/Integrations/FacebookInstantArticlesTest.php

Co-authored-by: Gary Jones <[email protected]>

Co-authored-by: Gary Jones <[email protected]>
@pauarge
Adding changelog for 3.0.0 (#495)
d869bee 
* Adding Changelog for 3.0

* Finishing up changelog
@pauarge
Remove unnecessary npm step in e2e (#494)
b5bf5fe 
* Shorter timeout for tests

* Not updating npm each time

* Shorter timeout

* Reverting changes on tests

* Removing custom jest

* Optimizing tests

* Removing explicit timeouts
@pauarge
Only running NodeJS checks with latest version (#499)
94f5fdc
@pauarge
Checking for updates in GitHub Actions (#498)
9e62159
@pauarge @sjinks
Merging trunk to develop. (#505)
a03e81d 
Co-authored-by: Volodymyr Kolesnykov <[email protected]>
@GaryJones @pauarge
Changelog: Add more detail for 3.0 release (#506)
afae6d0 
* Changelog: Add more detail for 3.0 release

* Update CHANGELOG.md

Co-authored-by: Pau Argelaguet <[email protected]>
@GaryJones
Deploy on published release
ffbb50c 
As per https://docs.github.com/en/actions/learn-github-actions/events-that-trigger-workflows#release, the workflow will only fire when we publish a release on GitHub. The `released` type will only fire for stable releases,  and not pre-release releases. 

This allows tagging and release of alpha and beta versions, without it automatically pushing to WPORG SVN which then result in sites pulling those in via plugin auto-updates.
@GaryJones GaryJones requested a review from a team as a code owner November 25, 2021 18:37
@sjinks
Copy link
Member

sjinks commented Nov 25, 2021

Not related to this PR, but this needs to be fixed:

https://github.com/Parsely/wp-parsely/pull/508/files#diff-28802fbf11c83a2eee09623fb192785e7ca92a3f40602a517c011b947a1822d3R13

      - name: Build # Remove or modify this step as needed
        run: |
          npm install
          npm run build

Consider using npm ci instead of npm install to make sure that you release what you have tested. npm ci installs exactly the same versions as specified in package-lock.json (and makes sure that package-lock.json matches package.json); npm install in some cases can update transitive dependencies.

@pauarge pauarge changed the base branch from develop to trunk November 25, 2021 19:49
@pauarge pauarge merged commit bb80bec into trunk Nov 25, 2021
@pauarge pauarge deleted the fix/deploy-on-published-release branch November 25, 2021 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauarge pauarge pauarge approved these changes

Assignees
No one assigned
Labels
Type: Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@GaryJones @sjinks @pauarge @mikeyarce @jblz @mchanDev