Skip to content

Commit

Permalink
2024-04-02 missing port-mapping quotes - master branch - PR 1 of 2
Browse files Browse the repository at this point in the history
Following on from discussion in SensorsIot#761, this adds quotes to port mappings
as recommended in docker-compose
[documentation](https://docs.docker.com/compose/compose-file/05-services/#short-syntax-3):

> HOST:CONTAINER should always be specified as a (quoted) string, to
avoid conflicts with
[yaml base-60 float](https://yaml.org/type/float.html)

Signed-off-by: Phill Kelley <[email protected]>
  • Loading branch information
Paraphraser committed Apr 2, 2024
1 parent 7a05f32 commit d399861
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .templates/dashmachine/service.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ dashmachine:
volumes:
- ./volumes/dashmachine/user_data:/dashmachine/dashmachine/user_data
ports:
- 5000:5000
- "5000:5000"
restart: unless-stopped

4 changes: 2 additions & 2 deletions .templates/heimdall/service.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ heimdall:
volumes:
- ./volumes/heimdall/config:/config
ports:
- 8882:80
- 8883:443
- "8882:80"
- "8883:443"
restart: unless-stopped

0 comments on commit d399861

Please sign in to comment.