Fix compatibility with both Ruby 2.7 and Ruby 3.0 #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not included in Ruby 3.0 standard lib anymore, so we should add it explicitly
Vagrant 2.3.* is still using Ruby 2.7 as the embedded ruby interpreter. We should not include a strict "required_ruby_version" in our gemfile, otherwise it won't be possible to install our plugin on Vagrant 2.3* or older. It's better to remove the line completely and rely on the compatibility defined by the upstream Vagrant.
- Pin `vagrant` to the latest release tag `v2.3.4`. Current `main` branch has unreleased changes which brakes our acceptance tests. Ref: hashicorp/vagrant#13052 (comment) - Pin `vagrant-spec` to a PR branch, which contains the fix for Ruby 3.0 runtime: hashicorp/vagrant-spec#56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gemspec: Add webrick dependency
It is not included in Ruby 3.0 standard lib anymore, so we should add it explicitly
gemspec: Fix compatibility with Ruby 2.7 and older
Vagrant 2.3.* is still using Ruby 2.7 as the embedded ruby interpreter. We should not include a strict "required_ruby_version"
in our gemfile, otherwise it won't be possible to install our plugin on Vagrant 2.3* or older.
It's better to remove the line completely and rely on the compatibility defined by the upstream Vagrant.
Gemfile: Update dev dependencies
vagrantto the latest release tagv2.3.4. Currentmainbranch has unreleased changes which brakes ouracceptance tests. Ref: Update connection settings when using a password to connect ssh hashicorp/vagrant#13052 (comment)
vagrant-specto a PR branch, which contains the fix for Ruby 3.0 runtime:subprocess: Fix the argument delegation with Ruby 3.0 hashicorp/vagrant-spec#56