Package machines as plain VMs, not templates #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are too messy. It's much better to use explicit arguments here.
|
👍 |
1 similar comment
|
👍 |
legal90
added a commit
that referenced
this pull request
Nov 9, 2015
Package machines as plain VMs, not templates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements GH-225
If the box contains a template (not a plain VM image), than it will be forcibly converted to the VM in the
BoxRegisteraction. It makes sense only for old-styled boxes, which includes templates instead of "plain "VM images inside.This is required for
linked_clonefeature. We can't create a linked clone for the template.While doing the
vagrant package, the resulted box will contain a plane VM image (not template), like any other Vagrant box created by Packer.cc: @Kasen @Gray-Wind @racktear