Fix port forwarding collisions in parallel run of multi-machine env #226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing a parallel run of multi-machine environment the race condition could happen:
This PR fixes that by adding adds both class- and process-level locks, so port forwarding will be proceeded subsequently.
Also, I've improved the
forward_ports
helper by decreasing the number of driver method calls. Now it should work a little bit faster.cc: @Gray-Wind @racktear @Kasen