Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add github workflow that checks sdist installation #41

Merged
merged 5 commits into from
Aug 9, 2024
Merged

Conversation

Jonathanlyj
Copy link
Collaborator

No description provided.

@wkliao
Copy link
Member

wkliao commented Aug 9, 2024

Why not doing this in the 2 already existing yaml files?

@Jonathanlyj
Copy link
Collaborator Author

Why not doing this in the 2 already existing yaml files?

If so we need to do pip uninstall pnetcdf first to refresh the env before re-installing with sdist. But pip uninstall doesn't clear the env entirely. I have seen the pip re-install is using some legacy metadata in *.egg-info folder is used in combination with new MANIFEST.in file. It's safest to build and test in a new env

@wkliao
Copy link
Member

wkliao commented Aug 9, 2024

Will running 'make install-clean' after 'pip uninstall' be sufficient?
See Makefile.

PnetCDF-Python/Makefile

Lines 32 to 33 in 4f1d279

install-clean: build-clean
rm -rf dist

@Jonathanlyj
Copy link
Collaborator Author

Will running 'make install-clean' after 'pip uninstall' be sufficient? See Makefile.

It works. Just updated the pr

@wkliao wkliao merged commit a99831b into main Aug 9, 2024
3 checks passed
@wkliao wkliao deleted the gh-action branch August 9, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants