Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configuration-example #1580

Merged
merged 2 commits into from
Nov 25, 2022
Merged

Conversation

cetvrtak
Copy link
Collaborator

@cetvrtak cetvrtak commented Nov 22, 2022

Fixes #1488

@cetvrtak cetvrtak requested a review from Idhrendur as a code owner November 22, 2022 15:58
Copy link
Member

@Idhrendur Idhrendur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on mobile so can't do comments properly, nor can I compare the actual converter output. But comparing to the fronter config, shouldn't ic_factor really be factory_factor? There's also a couple other options the example file is missing.

As well, it'd be nice to leave since comments with descriptions of the ranges or what the possible selections are.

@cetvrtak
Copy link
Collaborator Author

I'm on mobile so can't do comments properly, nor can I compare the actual converter output. But comparing to the fronter config, shouldn't ic_factor really be factory_factor? There's also a couple other options the example file is missing.

As well, it'd be nice to leave since comments with descriptions of the ranges or what the possible selections are.

Yes, I thought this was a simple edit. It will need a lot more work

@Idhrendur Idhrendur merged commit cf450bc into ParadoxGameConverters:master Nov 25, 2022
@cetvrtak cetvrtak deleted the config branch November 27, 2022 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

configuration-example.txt is out of date
2 participants