Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rajas of Asia support #568

Merged
merged 12 commits into from
Aug 21, 2024
Merged

Rajas of Asia support #568

merged 12 commits into from
Aug 21, 2024

Conversation

IhateTrains
Copy link
Member

@IhateTrains IhateTrains commented Aug 21, 2024

obraz

Uses autogenerated mappings with only 4 manual mappings (for cases where islands don't exist in EU4).

CK3 1066 start:
obraz

Conversion result:
20240821024830_1

Only problem I see is that some provinces have no area/region:

2024-08-21 02:39:57 [WARNING] Province ID 2200 has no parent area name!
2024-08-21 02:39:57 [WARNING] Province ID 2200 has no parent area name!
2024-08-21 02:39:57 [WARNING] Province ID 4401 has no parent area name!
2024-08-21 02:39:57 [WARNING] Province ID 4401 has no parent area name!
2024-08-21 02:39:57 [WARNING] Province ID 4159 has no parent area name!
2024-08-21 02:39:57 [WARNING] Province ID 4160 has no parent area name!
2024-08-21 02:39:57 [WARNING] Province ID 4159 has no parent area name!
2024-08-21 02:39:57 [WARNING] Province ID 4160 has no parent area name!
2024-08-21 02:39:57 [WARNING] Province ID 4178 has no parent area name!
2024-08-21 02:39:57 [WARNING] Province ID 4179 has no parent area name!
2024-08-21 02:39:57 [WARNING] Province ID 4178 has no parent area name!
2024-08-21 02:39:57 [WARNING] Province ID 4179 has no parent area name!
2024-08-21 02:39:57 [WARNING] Province ID 4155 has no parent area name!
2024-08-21 02:39:57 [WARNING] Province ID 4155 has no parent area name!
2024-08-21 02:39:57 [WARNING] Province ID 1793 has no parent area name!
2024-08-21 02:39:57 [WARNING] Province ID 4569 has no parent area name!
2024-08-21 02:39:57 [WARNING] Province ID 1793 has no parent area name!
2024-08-21 02:39:57 [WARNING] Province ID 4569 has no parent area name!
2024-08-21 02:39:57 [WARNING] Province ID 4146 has no parent area name!
2024-08-21 02:39:57 [WARNING] Province ID 4146 has no parent area name!
2024-08-21 02:39:57 [WARNING] Province ID 2334 has no parent area name!
2024-08-21 02:39:57 [WARNING] Province ID 4170 has no parent area name!
2024-08-21 02:39:57 [WARNING] Province ID 4172 has no parent area name!
2024-08-21 02:39:57 [WARNING] Province ID 4177 has no parent area name!
2024-08-21 02:39:57 [WARNING] Province ID 4328 has no parent area name!
2024-08-21 02:39:57 [WARNING] Province ID 2334 has no parent area name!
2024-08-21 02:39:57 [WARNING] Province ID 4170 has no parent area name!
2024-08-21 02:39:57 [WARNING] Province ID 4172 has no parent area name!
2024-08-21 02:39:57 [WARNING] Province ID 4177 has no parent area name!
2024-08-21 02:39:57 [WARNING] Province ID 4328 has no parent area name!
2024-08-21 02:39:57 [WARNING] Province ID 4657 has no parent area name!
2024-08-21 02:39:57 [WARNING] Province ID 4657 has no parent area name!
2024-08-21 02:39:57 [WARNING] Province ID 4402 has no parent area name!
2024-08-21 02:39:57 [WARNING] Province ID 4402 has no parent area name!
2024-08-21 02:39:57 [WARNING] Province ID 1784 has no parent area name!
2024-08-21 02:39:57 [WARNING] Province ID 1784 has no parent area name!
2024-08-21 02:39:57 [WARNING] Province ID 1786 has no parent area name!
2024-08-21 02:39:57 [WARNING] Province ID 1786 has no parent area name!

2024-08-21 02:39:57 [WARNING] Province ID 1799 has no parent region name!
2024-08-21 02:39:57 [WARNING] Province ID 4808 has no parent region name!
2024-08-21 02:39:57 [WARNING] Province ID 1794 has no parent region name!
2024-08-21 02:39:57 [WARNING] Province ID 4153 has no parent region name!
2024-08-21 02:39:57 [WARNING] Province ID 2425 has no parent region name!
2024-08-21 02:39:57 [WARNING] Province ID 2251 has no parent region name!
2024-08-21 02:39:57 [WARNING] Province ID 2129 has no parent region name!
2024-08-21 02:39:57 [WARNING] Province ID 2740 has no parent region name!
2024-08-21 02:39:57 [WARNING] Province ID 1789 has no parent region name!
2024-08-21 02:39:57 [WARNING] Province ID 1795 has no parent region name!

Can this be related to wastelands displaying as UNDEFINED in provinceMapper? I used MapDegrader beforehand.
Example from Iceland:
obraz

@IhateTrains IhateTrains requested a review from Zemurin as a code owner August 21, 2024 00:55
@Zemurin Zemurin merged commit 06ce33b into master Aug 21, 2024
10 checks passed
@Zemurin Zemurin deleted the roa-support branch August 21, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants