-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Potted plants size categories #28046
Open
ExusA
wants to merge
13
commits into
ParadiseSS13:master
Choose a base branch
from
ExusA:kirbyplants-sizes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+868
−822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bf51470.
ParadiseSS13-Bot
added
-Status: Awaiting type assignment
This PR is waiting for its type to be assigned internally
Map Edit
This PR will modify a map
labels
Jan 20, 2025
I used an updatepaths script for the map changes, this is my first time so I hope I did it correctly. |
Contrabang
added
Balance
This PR will modify how effective something is or isnt
Tweak
This PR tweaks something ingame
labels
Jan 20, 2025
ParadiseSS13-Bot
added
-Status: Awaiting approval
This PR is waiting for approval internally
and removed
-Status: Awaiting type assignment
This PR is waiting for its type to be assigned internally
labels
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
-Status: Awaiting approval
This PR is waiting for approval internally
Balance
This PR will modify how effective something is or isnt
Map Edit
This PR will modify a map
Sprites
This PR modifies the game sprites
Tweak
This PR tweaks something ingame
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
This categorizes Kirbyplants into Large, Medium, Small and Alien, and adds new spawners for each category which exclusively spawn their respective plants.
It repaths all the Kirbyplants into these categories and restricts the special interaction where you hide behind a plant to the large and alien plants, and allows picking up medium and small plants with one hand, and putting small ones in your bag.
The new small, medium and alien plant spawner mapping helpers aren't added to any maps, but they may be useful to mappers in the future. The current plant spawner mapping helpers has been replaced with Large helpers, which spawn large plants only.
Why It's Good For The Game
In most places where random kirbyplant spawners are mapped in, a larger plant looks way better than a tiny pot with a small flower in it. Conversely, there are places where a smaller kirbyplant would look great, like on tables and desks, but the spawner can't be used because a huge plant would look silly on a desk.
Almost all of the alien plants look pretty bad in hallways and rooms so having a new spawner will remove them from most places while keeping them available to put in alien places like explorable ruins, science, etc.
Removing the ability to hide behind non-large plants is a bit iffy and is more of a logical thing, but it should have minimal effect on balance, since most of the mapped in plants will be large ones now anyway- On metastation though, a lot of specific plant varieties are mapped in, so there will be modestly reduced opportunities for antags to hide behind plants there.
Images of changes
The new categories of the plants:
Plant 1-17 and Alien 1-8 are considered large plants.
Testing
Loaded up the game, looked at all the plants on the station. Spawned in a bunch of different random and specific plants and made sure they matched their spawner type.
Checked the webmap to make sure the mapped in specific plants all had the same icons on the webmap as in game.
Declaration
Changelog
🆑
tweak: Station potted plants are now bigger and less alien on average.
tweak: You can no longer hide behind small plants, but you can pick them up more easily.
/:cl: