-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A possible FPS lag fix caused by chat spam. #27292
Merged
Burzah
merged 6 commits into
ParadiseSS13:master
from
Spaghetti-bit:TGUIPreferenceStacking
Nov 6, 2024
Merged
A possible FPS lag fix caused by chat spam. #27292
Burzah
merged 6 commits into
ParadiseSS13:master
from
Spaghetti-bit:TGUIPreferenceStacking
Nov 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ParadiseSS13-Bot
added
-Status: Awaiting type assignment
This PR is waiting for its type to be assigned internally
TGUI
This PR modifies TGUI, will conflict
labels
Nov 4, 2024
I think i'll bring that animation back after 516 release |
ParadiseSS13-Bot
added
-Status: Awaiting review
This PR is awaiting review from the review team
and removed
-Status: Awaiting type assignment
This PR is waiting for its type to be assigned internally
labels
Nov 5, 2024
Burzah
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Burzah
added
Refactor
This PR will clean up the code but have the same ingame outcome
Fix
This PR will fix an issue in the game
labels
Nov 6, 2024
Let's fucking goooo, the game is playable again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
-Status: Awaiting review
This PR is awaiting review from the review team
Fix
This PR will fix an issue in the game
Refactor
This PR will clean up the code but have the same ingame outcome
TGUI
This PR modifies TGUI, will conflict
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Does This PR Do
This PR removes the animated 'blip' that appears on duplicated messages. This animated badge caused the textbox to expand and then rapidly shrink back to its original size. This is thought to cause a spike in lag when the chat is spammed by several duplicated messages updating their badges at once.
Why It's Good For The Game
It's a possible fix to the lag caused by chat spam, it's not an end-all-be-all but it has helped during testing.
Testing
(Even though it's hard to see through the videos and the FPS counter didn't show, there is a difference between the two. The non-animated badges performed slightly better; even better without admin logs.)
NoAnimatedBadges.mp4
AnimatedBadge.mp4
Strapped a skrell to a chair and shot them point blank with full admin logs on.
Declaration
Changelog
🆑
tweak: Tweaked how combinable messages work in an attempt to reduce lag from chat spam.
/:cl: