Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A possible FPS lag fix caused by chat spam. #27292

Merged
merged 6 commits into from
Nov 6, 2024

Conversation

Spaghetti-bit
Copy link
Contributor

What Does This PR Do

This PR removes the animated 'blip' that appears on duplicated messages. This animated badge caused the textbox to expand and then rapidly shrink back to its original size. This is thought to cause a spike in lag when the chat is spammed by several duplicated messages updating their badges at once.

  • Example: 3 people are spamming the hug emote on their plushies.

Why It's Good For The Game

It's a possible fix to the lag caused by chat spam, it's not an end-all-be-all but it has helped during testing.

Testing

(Even though it's hard to see through the videos and the FPS counter didn't show, there is a difference between the two. The non-animated badges performed slightly better; even better without admin logs.)

NoAnimatedBadges.mp4
AnimatedBadge.mp4

Strapped a skrell to a chair and shot them point blank with full admin logs on.


Declaration

  • I confirm that I either do not require pre-approval for this PR, or I have obtained such approval and have included a screenshot to demonstrate this below.

Changelog

🆑
tweak: Tweaked how combinable messages work in an attempt to reduce lag from chat spam.
/:cl:

@github-actions github-actions bot added the Merge Conflict This PR is merge conflicted label Nov 4, 2024
@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally TGUI This PR modifies TGUI, will conflict labels Nov 4, 2024
@AyIong
Copy link
Contributor

AyIong commented Nov 4, 2024

I think i'll bring that animation back after 516 release
But with some improvements

@ParadiseSS13-Bot ParadiseSS13-Bot added -Status: Awaiting review This PR is awaiting review from the review team and removed -Status: Awaiting type assignment This PR is waiting for its type to be assigned internally labels Nov 5, 2024
@github-actions github-actions bot removed the Merge Conflict This PR is merge conflicted label Nov 6, 2024
Copy link
Member

@Burzah Burzah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Burzah Burzah added Refactor This PR will clean up the code but have the same ingame outcome Fix This PR will fix an issue in the game labels Nov 6, 2024
@Burzah Burzah added this pull request to the merge queue Nov 6, 2024
Merged via the queue into ParadiseSS13:master with commit 0f5528f Nov 6, 2024
12 checks passed
@Scribble-Sheep
Copy link
Contributor

Let's fucking goooo, the game is playable again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-Status: Awaiting review This PR is awaiting review from the review team Fix This PR will fix an issue in the game Refactor This PR will clean up the code but have the same ingame outcome TGUI This PR modifies TGUI, will conflict
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants