Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.4 Feature - Time Clock Triggers - Scheduled Presets #163

Merged
merged 46 commits into from
Jul 14, 2023

Conversation

Jbithell
Copy link
Contributor

@Jbithell Jbithell commented Jun 15, 2023

Changelog

Checklist

  • I have added documentation for new/changed functionality in this PR
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not main

Test Checklist

Basics

  • Boots with a pre-existing database from the previous release, uploaded using the interface
  • Boots without a database, successfully creating its own
  • Reboots when reboot clicked
  • Quits when quit clicked

Presets/Faders/Folders

  • Presets/Faders/Folders can be added
  • Presets/Faders/Folders can be removed
  • Presets/Faders/Folders can be renamed, and this is reflected on the control panel
  • Presets/Folders can be disabled, and they are hidden from the control panel
  • Presets/Faders/Folders can be enabled, and they are shown in the control panel
  • Preset/Folders colors can be changed, and this is shown in the control panel
  • Preset/Faders/Folders sort order is maintained

Preset Types

sACN

  • sACN can be enabled/disabled
  • sACN data is output successfully

OSC

  • OSC can be enabled/disabled
  • OSC data is output successfully
  • X32 Faders are functional

HTTP

  • HTTP requests are made successfully

Macros

  • Macros are triggered successfully
  • Macros can trigger other macros

@Jbithell Jbithell changed the title Time Clock Triggers - Scheduled Presets v2.4 Feature - Time Clock Triggers - Scheduled Presets Jun 15, 2023
@Jbithell Jbithell self-assigned this Jul 8, 2023
@Jbithell Jbithell marked this pull request as ready for review July 14, 2023 17:47
@Jbithell Jbithell requested a review from cherry-john July 14, 2023 17:47
Copy link
Contributor

@cherry-john cherry-john left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cherry-john cherry-john merged commit 3750d5d into main Jul 14, 2023
@cherry-john cherry-john deleted the 150-feature-time-clock-triggers branch July 14, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Sampling mode is convinced fixtures are running an effect mode [FEATURE] Scheduled Macros
2 participants