Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add inviter name to invite email subject #9604

Merged
merged 4 commits into from
Apr 8, 2024
Merged

chore: Add inviter name to invite email subject #9604

merged 4 commits into from
Apr 8, 2024

Conversation

Mohd-Muneeb
Copy link
Contributor

@Mohd-Muneeb Mohd-Muneeb commented Apr 5, 2024

Description

Fixes/Partially Fixes #8949

Updated the message subject sent to the invitee by the inviter as mentioned in the issue.

Demo

Unavailable

Testing scenarios

No tests were performed, although type safety was ensured with standard measures

@dbumblis-parabol dbumblis-parabol removed their request for review April 5, 2024 04:38
@Mohd-Muneeb Mohd-Muneeb changed the title ⚡(enhancement)[8949] Editing invite message ⚡(refactor)[text fix] Editing invite message Apr 5, 2024
Copy link
Contributor

@Dschoordsch Dschoordsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this, could you make the small change?

packages/server/email/teamInviteEmailCreator.tsx Outdated Show resolved Hide resolved
@Dschoordsch Dschoordsch changed the title ⚡(refactor)[text fix] Editing invite message chore: Add inviter name to invite email subject Apr 8, 2024
@Dschoordsch
Copy link
Contributor

Thanks for the fix!

@Dschoordsch Dschoordsch merged commit cd5a3a8 into ParabolInc:master Apr 8, 2024
4 of 5 checks passed
@Mohd-Muneeb
Copy link
Contributor Author

:D

@Mohd-Muneeb Mohd-Muneeb deleted the editing-email-invite-message branch April 8, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show who is inviting you to Parabol
3 participants