Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make invoice row title more clear to understand #9551

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

tianrunhe
Copy link
Contributor

@tianrunhe tianrunhe commented Mar 20, 2024

Description

Fixes #8742

Demo

Screenshot 2024-03-19 at 17 52 00

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@tianrunhe tianrunhe marked this pull request as ready for review March 20, 2024 00:58
@tianrunhe tianrunhe requested a review from nickoferrall March 20, 2024 00:58
@tianrunhe tianrunhe added the Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved label Mar 20, 2024
@tianrunhe tianrunhe merged commit 9be96eb into master Mar 21, 2024
8 checks passed
@tianrunhe tianrunhe deleted the feat/clearInvoiceTitle branch March 21, 2024 18:05
@github-actions github-actions bot mentioned this pull request Mar 27, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/s Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show period dates on line item titles on the billing page
2 participants