Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): Test v7.12.0 #9314

Closed
wants to merge 73 commits into from
Closed

chore(release): Test v7.12.0 #9314

wants to merge 73 commits into from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 9, 2024

Production Job Id: 5896253347\nStaging Job Id: 5896253285\n\n## The basics

Run through this list at least once at staging:

  • Smoke tested the Demo, unauthenticated
  • Created an account
  • Verified invite via mass link works (Team > Invite Button > Invite Link, visit URL in an incognito window)
  • Verified invite via email works. It will show as logs in Datadog.
  • Added Slack, verified meeting notifications (use #t_product_actiontime)
  • Added Mattermost, verified meeting notifications (check the test webhook in Parabol Mattermost)
  • Added GitHub, verified issue created (use ParabolInc/publictestrepo)
  • Added Jira, verified issue created (use parabol-2)
  • Added GitLab, verified issue created
  • Added JiraServer, verified issue created
  • Smoke tested the Retro meeting with 2 players
  • Smoke tested the Sprint Poker meeting with 2 players
  • Smoke tested the Team Check-in meeting with 2 players
  • Smoke tested the Standup meeting with 2 players
  • Smoke tested cards on the dashboard
  • Created a 2nd team
  • Created a 2nd organization
  • Upgraded to Team (Credit card number: 4242 4242 4242 4242, expiration date: any month in the future, CVC: 123)
  • Upgraded to Team with a 3D Secure card (Credit card number: 4000 0000 0000 3063, expiration date: any month in the future, CVC: 123)
  • Tried and failed to upgrade with a card with insufficient funds (Credit card number: 4000 0000 0000 9995, expiration date: any month in the future, CVC: 123). Error feedback is shown in the UI.
  • Smoke tested the app on a mobile device (e.g. navigate between views, smoke test a Retro meeting, etc.)
  • Test previously existed meetings to make sure that existing data is not corrupted
  • Create a task in the discussion thread of a meeting
  • Create a comment in the discussion thread of a meeting

What’s changed

At your discretion, complete the tests for any merged PRs:

  • List each PR with a header and link to ([title], #[issue id])
  • Copy and paste tests, or note what was tested, in this issue
  • Run the equivalent test on staging that you would run in a local environment as closely as possible (e.g. updating the database to simulate cases, etc.)\n\n\n### Added

Fixed

Changed

  • Change email summary setting copy to be clearer (#9303) (176ce1e)
  • deps: bump tj-actions/changed-files in /.github/workflows (#9299) (8de6b80)
  • disable autoJoin test (#9304) (61d6842)
  • document SOCKET_PORT environment (#9309) (0d4d7db)
  • meeting-inception: use retrosInDisguise flag for displaying add an activity button (#9297) (126a1a0)

Dschoordsch and others added 30 commits November 13, 2023 11:06
* chore: Users with noTemplateLimit flag can use paid templates

* Don't show a lock if a user can access premium templates

regardless whether it's because their tier or a feature flag
* chore: Add SAML setup to new checkout flow

* Add Authorization also to mobile dash
Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com>
* feat: add GCS as a FileStore

Signed-off-by: Matt Krick <[email protected]>

* self-review: fix comments

Signed-off-by: Matt Krick <[email protected]>

* fix: checkExists

Signed-off-by: Matt Krick <[email protected]>

* dockerize testing the branch

* add recent filestore changes to gcs

Signed-off-by: Matt Krick <[email protected]>

* throw on trailing slash

Signed-off-by: Matt Krick <[email protected]>

* retry GCS flakey pushes

Signed-off-by: Matt Krick <[email protected]>

* dockerize

Signed-off-by: Matt Krick <[email protected]>

* bump yarn.lock

Signed-off-by: Matt Krick <[email protected]>

* fix yarn

Signed-off-by: Matt Krick <[email protected]>

---------

Signed-off-by: Matt Krick <[email protected]>
Co-authored-by: Rafael Romero <[email protected]>
…9162)

* chore: Users with noTemplateLimit flag can create custom templates

* Allow creating templates on legacy dialog with noTemplateLimit flag
* chore: test case: should not run for no migration

Signed-off-by: Matt Krick <[email protected]>

* test: working case

Signed-off-by: Matt Krick <[email protected]>

* test: failing case

Signed-off-by: Matt Krick <[email protected]>

* debug failing case

* test basename

Signed-off-by: Matt Krick <[email protected]>

* test working case

* better logs

Signed-off-by: Matt Krick <[email protected]>

* test no migration

Signed-off-by: Matt Krick <[email protected]>

---------

Signed-off-by: Matt Krick <[email protected]>
* fix: Avoid caching permissions with different arguments

Permissions are cached by function name. When these depend on the
arguments passed, they should have their own cache key, see
https://the-guild.dev/graphql/shield/docs/rules#limitations

* Make isViewerOnTeam strict

The passed function might access source or args and thus we should use
the strict cache.
* fix: sort team names alphabetically

* sort allTeamsOnOrg
Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com>
Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com>
* Sorted .env.example and added more documentation

* Added changes related to PR. Improved section naming.

* Fixed CI variable location

* Sorted variables and created new categories for GOOGLE, DATADOG, AWS. Added missing variables.

* Requested changes incorporated

---------

Co-authored-by: Rafael Romero <[email protected]>
* feat(trials): Start Trial mutation

* GQL + FE updates

* Copy update

* Minor fixes

* End Trial mutation

* Some cleanup

* More fixes

* Rename var

* Extract 'getFeatureTier'

* More cleanup

* Tiny cleanup

* CR: change to featureTier and billingTier

* CR: Misc fixes

* Rename featureTier back to just tier

* CR: Explicitly do OrgUser and User updates in order

* CR: Combine rethink queries

* Actually we don't need to do those in a specific order

* Why are tests broken

* Revert "CR: Combine rethink queries"

This reverts commit 04ad78d.

* Revert "Why are tests broken"

This reverts commit eca6417.

* Manually bisecting changes that break tests (part 1)

* Revert "Manually bisecting changes that break tests (part 1)"

This reverts commit db90ead.

* Revert "Revert "CR: Combine rethink queries""

This reverts commit a8c21a7.

* Fix tests 🤦

* Update trial copy for OrgPlansAndBillingHeading
* feat: Add Microsoft login

* Microsoft login button styling

* Add Microsoft login to forgot email and team invitation dialogs

* Cleanup and pseudoId

* Formatting

* Use colors from the palette for oauth login buttons

* Cleanup
* chore(kudos): add kudos team settings

* store emoji id
* chore(kudos): add kudos team settings

* store emoji id

* chore(kudos): add kudos record when adding emoji reaction

* Fix snackbar

* quick fix for types

* Dynamic emoji

* del console log

* Remove comment

* Remove unused kudos field

* expose senderUser

* Fix reactable type

* Fix table name

* Don't check feature flag

* Fix analytics

* Add snackbar events

* fix typescript
* chore(kudos): add kudos team settings

* store emoji id

* chore(kudos): add kudos record when adding emoji reaction

* Fix snackbar

* quick fix for types

* Dynamic emoji

* del console log

* feat(kudos): display notification when kudos received

* Remove comment

* Update notification text

* Remove unused kudos field

* expose senderUser

* Fix reactable type

* Fix table name

* remove unused fields

* Don't check feature flag

* Fix analytics

* Add snackbar events

* fix typescript

* Fix type

* Fix type

* add notification status analytics

* Fix type

* fix type

* Fix table name caused by wrong merge

* add snackbar clicked event to kudosReceived snackbar
* fix: author should be nullable when comment was anonymous

* fix: anonymous avatars path
Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com>
* remove gcal feature flag

* remove gcal feature flag

* fix provider list
mattkrick and others added 27 commits December 7, 2023 13:58
* chore: webpack client and server in parallel

Signed-off-by: Matt Krick <[email protected]>

* chore: cleanup my ugly code

Signed-off-by: Matt Krick <[email protected]>

---------

Signed-off-by: Matt Krick <[email protected]>
Prefer higher tiers and bigger over smaller orgs.
* feat: added option to modify icebreakers with ai

* code cleanup, analytics

* code cleanup

* fix: added success property to icebreaker modified analytics event

* refactor: use relay mutation helper for modify check in question mutation

* feat: add modified question char limit
* fix: no opaque responses

Signed-off-by: Matt Krick <[email protected]>

* add min bundle size

Signed-off-by: Matt Krick <[email protected]>

* fix: only dynamic cache parabol assets

Signed-off-by: Matt Krick <[email protected]>

---------

Signed-off-by: Matt Krick <[email protected]>
* feat: Show new meeting snack also on summary page

Because the meeting summary shows the sidebar as well, this feels more
in line with the user expectation.

* Fix demo
When no organization feature flag was present, we would not show the
prompt to join org notification.
* fix: Prompt to join org without organization feature flags

When no organization feature flag was present, we would not show the
prompt to join org notification.

* fix: Update organization on accept invite

When accepting an invite in a different tab, or if the team lead accepts
a prompt to join org invite, the new organization was added partially to
the viewers organization causing undefined errors.
* chore: release to staging from github

Signed-off-by: Matt Krick <[email protected]>

* chore: push to prod on PR merge

Signed-off-by: Matt Krick <[email protected]>

* fix: naming

Signed-off-by: Matt Krick <[email protected]>

* fix: hotfix branch name prefix

Signed-off-by: Matt Krick <[email protected]>

* fix: poll for pipeline in staging

Signed-off-by: Matt Krick <[email protected]>

---------

Signed-off-by: Matt Krick <[email protected]>
Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com>
* fix: Fix duplicate organizations for teams with auto join

If an organization had multiple teams with `autoJoin` enabled, multiple
`OrganizationUser` objects would be created for a new user.

This fixes the creation of duplicate `OrganizationUser` objects but does
not fix the existing duplicates. Ideally we would add a migration for
this, but filtering over all `OrganizationUser` entries is expensive and
only the Parabol org is affected.

* Add test

* Fix adjustUserCount properly instead
Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com>
Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com>
The test fails randomly, supposedly because the underlying issue is not
completely fixed yet. This should be fixed in #9302, until then let's
unblock CI.
Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 40 to 41.
- [Release notes](https://github.com/tj-actions/changed-files/releases)
- [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md)
- [Commits](tj-actions/changed-files@v40...v41)

---
updated-dependencies:
- dependency-name: tj-actions/changed-files
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat(kudos): send kudos by text in standups

* Remove console logs

* Fix test

* Store unicode emoji too

* Link teamPromptResponseId

* Update slack notification

* Update email notification

* Mention notification analytics

* response mentioned toast analytics

* isValid

* Add types
Co-authored-by: parabol-release-bot[bot] <150284312+parabol-release-bot[bot]@users.noreply.github.com>
@mattkrick
Copy link
Member

GRRRR newlines are broken 😢 . will try again!

@mattkrick mattkrick closed this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.