Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added three seed projects for new team leader. #635

Merged
merged 3 commits into from
Jan 16, 2017
Merged

Conversation

jordanh
Copy link
Contributor

@jordanh jordanh commented Jan 14, 2017

Implements #632

@ackernaut
Copy link
Member

Oh snap!

updatedAt: now
}));

return await r.table('Project').insert(seedProjects)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this work without the returnChanges: true option?

@jordanh
Copy link
Contributor Author

jordanh commented Jan 16, 2017

Whoa @mattkrick good catch on the returnChanges. You know, I tested it and it did work and still worked without returnChanges. Makes me wonder what the defaults of our driver are...cause the rethinkdb doc defaults definitely have returnChanges: false.

@jordanh
Copy link
Contributor Author

jordanh commented Jan 16, 2017

GTG now?

@jordanh jordanh merged commit 3a71636 into master Jan 16, 2017
@jordanh jordanh removed the pr review label Jan 16, 2017
@jordanh jordanh deleted the qfunnel-seed-projects branch January 16, 2017 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants