First stab at CircleCI 2.0 beta config #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mysteries yet to solve: * Why doesn’t UserSettingsContainer update after mutation? * Why doesn’t the S3 object actually delete?
Build changes:
* No longer builds client and server concurently, client
depends on prerender.js
* `npm run build:client-min` no longer deploys by default
* `npm run build:deploy` is the hot new deployment command
S3 documentation captures these changes, and our S3 infrastructure setup.
Code review revisions: * use 1 validation for `Step1Schema` and `UpdatedUserSchema` * stop deleting old user images * rename `protoRelUrl` to `protocolRelativeUrl` * refactor extension of url in `protoRelUrl` for greater readability * use promisify in src/server/utils/s3.js * thunkify src/universal/components/FileInput/FileInput.js:11 Restored concurrency to `npm run build`. Added build commands `build:min` and `build:deploy`. Fixed #602
Useful for local development
Now with: * content-length restriction * client & server type validation Note: tackling multipart ended up being a headache. It'll take a few days. Hooking into the AWS API request lifecycle to add Content-Length was a big breakthrough.
- [x] update src/server/graphql/models/User/userSchema.js:141 description - [x] change createUserPutPictureUrl to only accept a MIME type arg, return URL - [x] nuke unecessary rethinkdb access from createUserPutPictureUrl - [x] propagate raven exceptions when avatar uploads fail on client
Changing webpack min and deploy options Added WEBPACK_MIN and WEBPACK_DEPLOY in lieu of DEPLOY and CI flags in webpack.config.prod.js. Changed circle.yml to use them. Pulled these changes from s3-user-assets branch.
|
@mattkrick a little snowy ❄️ Saturday hack session had me generate this new CircleCI 2.0 beta configuration. It is RAD. This sucker lints, tests, build, and deploys. This means any of us with merge rights will be able to merge to staging (and later production) and deploy code. I'm stoked. |
S3 user assets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes webpack min and deploy options.
Added WEBPACK_MIN and WEBPACK_DEPLOY in lieu of DEPLOY and CI flags in webpack.config.prod.js. Changed circle.yml to use them. Pulled these changes from
s3-user-assetsbranch.