Jira Server: show integrated task #6092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@igorlesnenko , I cherry-picked #6104 into this branch to unblock you. Just FYI in case you see merge conflicts from it. |
…ol into jira-server-show-task
… into jira-server-show-task
Dschoordsch
requested changes
Feb 25, 2022
…ol into jira-server-show-task
Dschoordsch
requested changes
Mar 3, 2022
|
merged into #6059 as easier to test and do changes |
mattkrick
added a commit
that referenced
this pull request
Mar 25, 2022
* Add generic createTaskIntegration mutation * Simplify * Remove old mutations * Update demo * Use existing integration provider service * authLoaderKey instead of returning data loader * Move db actions outside * getCreatedBySomeoneElseComment * Remove internal state * Add manager factory * Tweak variable names * Add mask false * Allow to use any custom auth loader * Simplify * fix @relay(mask: false) bug * Change CreateTaskResponse * Change CreateTaskResponse * Rename projectId to integrationRepoId * Formatting * Add Jira Server to RepoIntegrations * Remove added id from GitHub schema It already has an id. * Tweak graphql.ts * Add JiraServerTaskintegrationManager * addComment * Fix comment * Add avatar fetching for Jira Server * Fix TypeError: jiraProjects is not iterable * Tweak type * use useFragment instead of createFragmentContainer * Cleanup JiraServerIntegraiton GraphQL types * Convert fetchJiraServerProjects into a dataloader * Improve JiraServerRestManager error reporting * Fix JiraServerRestManager request * Jira Server: show integrated task (#6092) * Jira Server: show integrated task * Tweak import paths for circleci build * build(server): fix jest transforms * Tweak isTypeOf * Tweak naming * Do not call factory from dataloader Co-authored-by: Ben Limmer <[email protected]> * Fix IntegrationRepoId * Clean up * Fix issueKey * Fix provider id type * ids split - assume the input is valid and return non-null types * Simplify * Specific type * Replace interface with AbstractTaskIntegrationManager * Replace getCreatedBySomeoneElseComment with add * Jira server - store issueId and repositoryId * Use interface, store context and info in state * Merge Jira Server integration manager into JiraServerRestManager * Rename GitHub integration manager to GitHubServerManager * Make jira integration manager similar to others * Update JiraServer icon Co-authored-by: Matt Krick <[email protected]> Co-authored-by: Georg Bremer <[email protected]> Co-authored-by: Ben Limmer <[email protected]>
igorlesnenko
added a commit
that referenced
this pull request
Mar 30, 2022
* Add generic createTaskIntegration mutation * Simplify * Remove old mutations * Update demo * Use existing integration provider service * authLoaderKey instead of returning data loader * Move db actions outside * getCreatedBySomeoneElseComment * Remove internal state * Add manager factory * Tweak variable names * Add mask false * Allow to use any custom auth loader * Simplify * fix @relay(mask: false) bug * Change CreateTaskResponse * Change CreateTaskResponse * Rename projectId to integrationRepoId * Formatting * Add Jira Server to RepoIntegrations * Remove added id from GitHub schema It already has an id. * Tweak graphql.ts * Add JiraServerTaskintegrationManager * addComment * Fix comment * Jira Server: show integrated task * Tweak import paths for circleci build * Add avatar fetching for Jira Server * build(server): fix jest transforms * Fix TypeError: jiraProjects is not iterable * Tweak type * Tweak isTypeOf * use useFragment instead of createFragmentContainer * Cleanup JiraServerIntegraiton GraphQL types * Convert fetchJiraServerProjects into a dataloader * Improve JiraServerRestManager error reporting * feat(jira-server): List issues in sprint poker * Fix JiraServerRestManager request * Jira Server: show integrated task (#6092) * Jira Server: show integrated task * Tweak import paths for circleci build * build(server): fix jest transforms * Tweak isTypeOf * Tweak naming * Do not call factory from dataloader Co-authored-by: Ben Limmer <[email protected]> * Fix IntegrationRepoId * Clean up * Fix issueKey * Fix provider id type * add jiraServer feature flag * Remove jiraServer feature flag * getApiManager * Fix initManager type * Add MockScopingList * ids split - assume the input is valid and return non-null types * Simplify * Specific type * Tweak poker tabs * Call integration manager directly * Remove fetch jira server projects * Replace interface with AbstractTaskIntegrationManager * Replace interface with AbstractTaskIntegrationManager * Replace getCreatedBySomeoneElseComment with add * Jira server - store issueId and repositoryId * Use interface, store context and info in state * Merge Jira Server integration manager into JiraServerRestManager * Rename GitHub integration manager to GitHubServerManager * Make jira integration manager similar to others * Update JiraServer icon * non-null addCreatedBySomeoneElseComment Co-authored-by: Matt Krick <[email protected]> Co-authored-by: Georg Bremer <[email protected]> Co-authored-by: Ben Limmer <[email protected]>
mattkrick
added a commit
that referenced
this pull request
Apr 1, 2022
* Add generic createTaskIntegration mutation * Simplify * Remove old mutations * Update demo * Use existing integration provider service * authLoaderKey instead of returning data loader * Move db actions outside * getCreatedBySomeoneElseComment * Remove internal state * Add manager factory * Tweak variable names * Add mask false * Allow to use any custom auth loader * Simplify * fix @relay(mask: false) bug * Change CreateTaskResponse * Change CreateTaskResponse * Rename projectId to integrationRepoId * Formatting * Add Jira Server to RepoIntegrations * Remove added id from GitHub schema It already has an id. * Tweak graphql.ts * Add JiraServerTaskintegrationManager * addComment * Fix comment * Jira Server: show integrated task * Tweak import paths for circleci build * Add avatar fetching for Jira Server * build(server): fix jest transforms * Fix TypeError: jiraProjects is not iterable * Tweak type * Tweak isTypeOf * use useFragment instead of createFragmentContainer * Cleanup JiraServerIntegraiton GraphQL types * Convert fetchJiraServerProjects into a dataloader * Improve JiraServerRestManager error reporting * feat(jira-server): List issues in sprint poker * Fix JiraServerRestManager request * Jira Server: show integrated task (#6092) * Jira Server: show integrated task * Tweak import paths for circleci build * build(server): fix jest transforms * Tweak isTypeOf * Tweak naming * Do not call factory from dataloader Co-authored-by: Ben Limmer <[email protected]> * Fix IntegrationRepoId * Clean up * Fix issueKey * Fix provider id type * add jiraServer feature flag * Remove jiraServer feature flag * getApiManager * Fix initManager type * Add MockScopingList * Allow adding a Jira Server task to poker scope * Show Jira Server description * ids split - assume the input is valid and return non-null types * Simplify * Specific type * Tweak poker tabs * Call integration manager directly * Remove fetch jira server projects * Replace interface with AbstractTaskIntegrationManager * Replace interface with AbstractTaskIntegrationManager * Replace getCreatedBySomeoneElseComment with add * Jira server - store issueId and repositoryId * Use interface, store context and info in state * Merge Jira Server integration manager into JiraServerRestManager * Rename GitHub integration manager to GitHubServerManager * Make jira integration manager similar to others * Update JiraServer icon * add types * Remove redundant headers * Remove AbstractTaskIntegrationManager * PokerEstimateHeaderCardContent * Revert ImportedTask Co-authored-by: Matt Krick <[email protected]> Co-authored-by: Georg Bremer <[email protected]> Co-authored-by: Ben Limmer <[email protected]>
jmtaber129
pushed a commit
that referenced
this pull request
Apr 5, 2022
* Add generic createTaskIntegration mutation * Simplify * Remove old mutations * Update demo * Use existing integration provider service * authLoaderKey instead of returning data loader * Move db actions outside * getCreatedBySomeoneElseComment * Remove internal state * Add manager factory * Tweak variable names * Add mask false * Allow to use any custom auth loader * Simplify * fix @relay(mask: false) bug * Change CreateTaskResponse * Change CreateTaskResponse * Rename projectId to integrationRepoId * Formatting * Add Jira Server to RepoIntegrations * Remove added id from GitHub schema It already has an id. * Tweak graphql.ts * Add JiraServerTaskintegrationManager * addComment * Fix comment * Jira Server: show integrated task * Tweak import paths for circleci build * Add avatar fetching for Jira Server * build(server): fix jest transforms * Fix TypeError: jiraProjects is not iterable * Tweak type * Tweak isTypeOf * use useFragment instead of createFragmentContainer * Cleanup JiraServerIntegraiton GraphQL types * Convert fetchJiraServerProjects into a dataloader * Improve JiraServerRestManager error reporting * feat(jira-server): List issues in sprint poker * Fix JiraServerRestManager request * Jira Server: show integrated task (#6092) * Jira Server: show integrated task * Tweak import paths for circleci build * build(server): fix jest transforms * Tweak isTypeOf * Tweak naming * Do not call factory from dataloader Co-authored-by: Ben Limmer <[email protected]> * Fix IntegrationRepoId * Clean up * Fix issueKey * Fix provider id type * add jiraServer feature flag * Remove jiraServer feature flag * getApiManager * Fix initManager type * Add MockScopingList * ids split - assume the input is valid and return non-null types * Simplify * Specific type * Tweak poker tabs * Call integration manager directly * Remove fetch jira server projects * Replace interface with AbstractTaskIntegrationManager * Replace interface with AbstractTaskIntegrationManager * Replace getCreatedBySomeoneElseComment with add * Jira server - store issueId and repositoryId * Use interface, store context and info in state * Merge Jira Server integration manager into JiraServerRestManager * Rename GitHub integration manager to GitHubServerManager * Make jira integration manager similar to others * Update JiraServer icon * non-null addCreatedBySomeoneElseComment Co-authored-by: Matt Krick <[email protected]> Co-authored-by: Georg Bremer <[email protected]> Co-authored-by: Ben Limmer <[email protected]>
jmtaber129
pushed a commit
that referenced
this pull request
Apr 5, 2022
* Add generic createTaskIntegration mutation * Simplify * Remove old mutations * Update demo * Use existing integration provider service * authLoaderKey instead of returning data loader * Move db actions outside * getCreatedBySomeoneElseComment * Remove internal state * Add manager factory * Tweak variable names * Add mask false * Allow to use any custom auth loader * Simplify * fix @relay(mask: false) bug * Change CreateTaskResponse * Change CreateTaskResponse * Rename projectId to integrationRepoId * Formatting * Add Jira Server to RepoIntegrations * Remove added id from GitHub schema It already has an id. * Tweak graphql.ts * Add JiraServerTaskintegrationManager * addComment * Fix comment * Jira Server: show integrated task * Tweak import paths for circleci build * Add avatar fetching for Jira Server * build(server): fix jest transforms * Fix TypeError: jiraProjects is not iterable * Tweak type * Tweak isTypeOf * use useFragment instead of createFragmentContainer * Cleanup JiraServerIntegraiton GraphQL types * Convert fetchJiraServerProjects into a dataloader * Improve JiraServerRestManager error reporting * feat(jira-server): List issues in sprint poker * Fix JiraServerRestManager request * Jira Server: show integrated task (#6092) * Jira Server: show integrated task * Tweak import paths for circleci build * build(server): fix jest transforms * Tweak isTypeOf * Tweak naming * Do not call factory from dataloader Co-authored-by: Ben Limmer <[email protected]> * Fix IntegrationRepoId * Clean up * Fix issueKey * Fix provider id type * add jiraServer feature flag * Remove jiraServer feature flag * getApiManager * Fix initManager type * Add MockScopingList * Allow adding a Jira Server task to poker scope * Show Jira Server description * ids split - assume the input is valid and return non-null types * Simplify * Specific type * Tweak poker tabs * Call integration manager directly * Remove fetch jira server projects * Replace interface with AbstractTaskIntegrationManager * Replace interface with AbstractTaskIntegrationManager * Replace getCreatedBySomeoneElseComment with add * Jira server - store issueId and repositoryId * Use interface, store context and info in state * Merge Jira Server integration manager into JiraServerRestManager * Rename GitHub integration manager to GitHubServerManager * Make jira integration manager similar to others * Update JiraServer icon * add types * Remove redundant headers * Remove AbstractTaskIntegrationManager * PokerEstimateHeaderCardContent * Revert ImportedTask Co-authored-by: Matt Krick <[email protected]> Co-authored-by: Georg Bremer <[email protected]> Co-authored-by: Ben Limmer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5994
Needs #6059
How to test: