Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: notification settings UI #10695

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Conversation

Dschoordsch
Copy link
Contributor

Description

Partially Fixes #10647
Add UI to modify the notification settings for MS Teams and Mattermost

Demo

image

Testing scenarios

[Please list all the testing scenarios a reviewer has to check before approving the PR]

  • Scenario A

    • Step 1
    • Step 2...
  • Scenario B

    • Step 1
    • Step 2....

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@Dschoordsch Dschoordsch changed the base branch from master to feat/10647/addMattermostNotificationSettings January 16, 2025 14:30
@Dschoordsch Dschoordsch changed the title Feat/10647/notification settings UI feat: notification settings UI Jan 16, 2025
Base automatically changed from feat/10647/addMattermostNotificationSettings to master January 21, 2025 15:27
@Dschoordsch Dschoordsch force-pushed the feat/10647/notificationSettingsUI branch from b56f086 to 7f8ceed Compare January 21, 2025 15:30
If the user has disabled the notification for stage timers, it would be
misleading to show this. We show it however if either start or end timer
events are enabled.
@Dschoordsch Dschoordsch merged commit 0e79cdb into master Jan 21, 2025
6 checks passed
@Dschoordsch Dschoordsch deleted the feat/10647/notificationSettingsUI branch January 21, 2025 17:19
Copy link

sentry-io bot commented Jan 22, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Cannot read properties of undefined (reading 'includes') isNotificationActive(packages/client/components... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mattermost (in Parabol): Add notification settings
1 participant