-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(orgAdmins): show total user & team counts #10396
Conversation
<StyledRowInfoCopy> | ||
{`${totalUsers} ${plural(totalUsers, 'User')} (${activeUserCount} Active)`} | ||
</StyledRowInfoCopy> | ||
<StyledRowInfoCopy>{`${totalUsers} ${plural(totalUsers, 'User')}`}</StyledRowInfoCopy> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-1 we're removing active
for all users here. It's still relevant for Team users, so I think it should only be hidden for Enterprise users
@@ -131,6 +139,30 @@ const OrgPlans = (props: Props) => { | |||
return ( | |||
<> | |||
<StyledPanel label='Plans'> | |||
{billingTier === 'enterprise' && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 the plans section doesn't feel like the right place for this, to me. The plans explain what is offered in each tier, whereas this is information about usage.
I'm happy to still approve the PR if that's where you and @charlesmathias what to put it, but I'd suggest checking with @ackernaut first
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sooner or later I’d like to create a usage section that is separate from the tiers and plans setion(s). Kind of like variants we’ve explored here 🔒 . It doesn’t have to happen in this PR.
I would like to see the usage section always at the top, regardless of how the other sections appear or are ordered below. If we need to add some special case banner to alert something at the very top, probably something that can be dismissed, we can always consider that later.
Description
Fixes #10393
Demo
Testing scenarios
[Please list all the testing scenarios a reviewer has to check before approving the PR]
Organizations page show total user count
http://localhost:3000/me/organizations
Enterprise plan show total number of teams and users
http://localhost:3000/me/organizations/xxxxx/billing
Final checklist