feat: add Insights UI skeleton #10254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @ackernaut, would you mind reviewing the UI in this PR to see if it's on the right track? I won't merge the PR until the team feature flag is ready. That way, we can release the feature to just Parabol and select teams. |
nickoferrall
requested review from
ackernaut
and removed request for
ackernaut
|
Hey! I’ll take a card to review this. Thanks! |
ackernaut
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Hey Nick! Looking good. I made a small commit and PR refining a few small things. For the sheet we will end up hanging controls into a 56px left margin and I had the right margin matching since we have the space (I like the balancing effect). At some point we will also need to think about how this shrinks down responsively. I can take a task to add some mobile views in Figma.
|
See #10274 |
|
Perfect, thank you Terry! |
nickoferrall
added a commit
that referenced
this pull request
Oct 16, 2024
This reverts commit aa8e931.
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10238
This PR won't be merged until we've added the Team feature flag.
AC