Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(rethinkdb): NewMeeting: Phase 1a #10216

Merged
merged 47 commits into from
Sep 27, 2024
Merged

chore(rethinkdb): NewMeeting: Phase 1a #10216

merged 47 commits into from
Sep 27, 2024

Conversation

mattkrick
Copy link
Member

@mattkrick mattkrick commented Sep 11, 2024 •
edited
Loading

Description

This PR should not really affect runtime.
Validation of meetingType is performed at runtime instead of assumed as a typescript coercion. This gets rid of 90% of the manual coercion we were doing.
I created some strict types based off the NewMeeting table in PG
These types will save us as we move forward with the migration.
These changes assume we don't handle undefined differently from null in RethinkDB. I think we're OK on that front.

With the correct types in place, we'll later be able to read from RethinkDB or PG and assume roughly the same type

mattkrick added 30 commits August 27, 2024 12:52
@mattkrick
chore: write to PG
bbd3d12 
Signed-off-by: Matt Krick <[email protected]>
@mattkrick
fix: refactor comment to SDL
217606e 
Signed-off-by: Matt Krick <[email protected]>
@mattkrick
add comment
fd13993 
Signed-off-by: Matt Krick <[email protected]>
@mattkrick
Merge branch 'master' into chore/Comment-phase1
918b493
@mattkrick
migrate existing Comments
424a54b 
Signed-off-by: Matt Krick <[email protected]>
@mattkrick
switch reads to PG
c0278ae 
Signed-off-by: Matt Krick <[email protected]>
@mattkrick
fix replies
4cf9c8f 
Signed-off-by: Matt Krick <[email protected]>
@mattkrick
Merge branch 'master' into chore/Comment-phase3
d61559a 
Signed-off-by: Matt Krick <[email protected]>
@mattkrick
init migration
da853e7
@mattkrick
add writes to PG
fb941f6
@mattkrick
Merge branch 'master' into chore/ReflectPrompt-phase1
0efe604
@mattkrick
refactor add/move reflect template prompt to sdl
814d9ef
@mattkrick
refactor 4 mutations to sdl
134b3b6
@mattkrick
fix downmigration
2f8cf27 
Signed-off-by: Matt Krick <[email protected]>
@mattkrick
Merge branch 'master' into chore/ReflectPrompt-phase1
9f372a1
@mattkrick
use explicit columns
171ded7 
Signed-off-by: Matt Krick <[email protected]>
@mattkrick
migrate existing rows
a38beb4 
Signed-off-by: Matt Krick <[email protected]>
@mattkrick
progress
8a64083
@mattkrick
use explicit props
fcc66a9
@mattkrick
use explicit props nullable
c44f72c
@mattkrick
Merge branch 'chore/ReflectPrompt-phase1' into chore/ReflectPrompt-ph…
9c2b951 
…ase3
@mattkrick
remove writes to R
e628e0b 
Signed-off-by: Matt Krick <[email protected]>
@mattkrick
fix tsc
21fc97c 
Signed-off-by: Matt Krick <[email protected]>
@mattkrick
fix bad old migrations referencing types
ec73789 
Signed-off-by: Matt Krick <[email protected]>
@mattkrick
Merge branch 'chore/ReflectPrompt-phase1' into chore/ReflectPrompt-ph…
d18a710 
…ase2
@mattkrick
Merge branch 'chore/ReflectPrompt-phase2' into chore/ReflectPrompt-ph…
551ce33 
…ase3

Signed-off-by: Matt Krick <[email protected]>
@mattkrick
chore: migrate PasswordResetRequest
726f632 
Signed-off-by: Matt Krick <[email protected]>
@mattkrick
use 2 queries for resets
9c7839d 
Signed-off-by: Matt Krick <[email protected]>
@mattkrick
clean up clientside sortOrder
89040df 
Signed-off-by: Matt Krick <[email protected]>
@mattkrick
Merge branch 'master' into chore/ReflectPrompt-phase2
5843139
@github-actions github-actions bot added size/xl and removed size/m labels Sep 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@github-actions GitHub Actions
Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@github-actions GitHub Actions
Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@mattkrick mattkrick changed the title chore(rethinkdb): NewMeeting: Phase 1 chore(rethinkdb): NewMeeting: Phase 1a Sep 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@mattkrick mattkrick marked this pull request as ready for review September 12, 2024 22:30
@github-actions GitHub Actions
Copy link
Contributor

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR will be delayed and might be rejected due to its size.

@github-actions github-actions bot added size/l and removed size/xl labels Sep 13, 2024
@mattkrick mattkrick merged commit 6273411 into master Sep 27, 2024
7 checks passed
@mattkrick mattkrick deleted the chore/NewMeeting-phase1 branch September 27, 2024 19:03
@parabol-release-bot parabol-release-bot bot mentioned this pull request Sep 27, 2024
Merged
@github-actions github-actions bot mentioned this pull request Sep 27, 2024
Merged
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size/l
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mattkrick