Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(orgAdmins): Billing leaders should not see all teams in the org #10141

Conversation

tianrunhe
Copy link
Contributor

@tianrunhe tianrunhe commented Aug 19, 2024

Description

Fixes #10080

Testing scenarios

  • Billing lead

    • Go to http://localhost:3000/me/organizations/xxxx/teams
    • Can only see the teams the billing lead is in
    • Click into a team, can delete the team
  • Org Admin

    • Go to http://localhost:3000/me/organizations/xxxx/teams
    • Can see all teams within the org
    • Click into any teams, can delete them

Final checklist

  • I checked the code review guidelines
  • I have added Metrics Representative as reviewer(s) if my PR invovles metrics/data/analytics related changes
  • I have performed a self-review of my code, the same way I'd do it for any other team member
  • I have tested all cases I listed in the testing scenarios and I haven't found any issues or regressions
  • Whenever I took a non-obvious choice I added a comment explaining why I did it this way
  • I added the label Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved if the PR introduces only minor changes, does not contain any architectural changes or does not introduce any new patterns and I think one review is sufficient'
  • PR title is human readable and could be used in changelog

@tianrunhe tianrunhe linked an issue Aug 19, 2024 that may be closed by this pull request
@tianrunhe tianrunhe changed the title fix(orgAdmins): Billing leaders cannot see all teams fix(orgAdmins): Billing leaders should not see all teams in the org Aug 19, 2024
@tianrunhe tianrunhe requested a review from nickoferrall August 19, 2024 21:41
@tianrunhe tianrunhe added the Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved label Aug 19, 2024
@tianrunhe tianrunhe merged commit cd570ac into master Aug 22, 2024
9 checks passed
@tianrunhe tianrunhe deleted the 10080-some-org-admin-permissions-are-available-to-billing-leaders branch August 22, 2024 14:54
@github-actions github-actions bot mentioned this pull request Aug 22, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/s Skip Maintainer Review Indicating the PR only requires reviewer review and can be merged right after it's approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some Org Admin permissions are available to Billing Leaders
2 participants