Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update meeting summary UI #10081

Merged
merged 51 commits into from
Aug 12, 2024
Merged

feat: update meeting summary UI #10081

merged 51 commits into from
Aug 12, 2024

Conversation

nickoferrall
Copy link
Contributor

Fix #10040

To test

  • Replace wholeMeetingSummary here with dummy text that has markdown, e.g.: The budget work is recognized for its future value in improving focus and communication within the team ([link](https://action.parabol.co/meet/twbP2qPXNK/discuss/3](https://action.parabol.co/meet/twbP2qPXNK/discuss/3) )).'
  • See that the link shows up as a formatted link

nickoferrall added 30 commits July 1, 2024 16:43
@nickoferrall
add generateInsight mutation
05250cf
@nickoferrall
replace shortUrls with real urls
c4ef355
@nickoferrall
handle teamId arg and replace short meeting ids
450b9c2
@nickoferrall
add orgId arg to generateInsight
c806eca
@nickoferrall
filter meetings more efficiently
e262f9f
@nickoferrall
return wins and challenges from generateInsight
3e4aff4
@nickoferrall
Merge branch 'feat/generate-insight' into feat/generate-team-insight
b0b042e
@nickoferrall
generate insight
14a34dc
@nickoferrall
implement addInsight migration
7792681
@nickoferrall
check for existingInsight
7c02ca4
@nickoferrall
start summary of summaries
91e56b0
@nickoferrall
include links to discussions
a0f2607
@nickoferrall
update prompt
adc15ac
@nickoferrall
return summary if exists
3b939b1
@nickoferrall
update prompt and clean up processing getTopics meetingId
cebc7b3
@nickoferrall
remove generated files
e15d1e7
@nickoferrall
remove meetingSummary yaml file
23448b1
@nickoferrall
update short meeting date
fde4584
@nickoferrall
Merge branch 'master' into feat/summary-of-summaries
555ec41
@nickoferrall
move addInsight migration after merging master
ca5c6fc
@nickoferrall
fix insight start end date insert
6e5aeeb
@nickoferrall
return prev insight if dates and teamid exist
5b1964e
@nickoferrall
update generate insight prompt to reduce jargon
bc7b351
@nickoferrall
update migration to make wins and challenges non null
f9e3449
@nickoferrall
accept prompt as arg in generateInsight
aeb8fa8
@nickoferrall
update migration order
cc9768c
@nickoferrall
remove meetings from generateInsight query
a3ba8d0
@nickoferrall
use number.isNaN instead
5c191ef
@nickoferrall
generate new meeting summary
a5c6a61
@nickoferrall
create new summaries for old meetings
e082197
@github-actions github-actions bot added the size/s label Aug 6, 2024
@nickoferrall nickoferrall marked this pull request as ready for review August 6, 2024 17:03
Base automatically changed from feat/10038/new-meeting-summary to master August 7, 2024 14:53
@nickoferrall nickoferrall removed the request for review from Dschoordsch August 8, 2024 15:27
@nickoferrall nickoferrall changed the base branch from master to staging-backup August 8, 2024 15:28
@nickoferrall nickoferrall changed the base branch from staging-backup to master August 8, 2024 15:28
Dschoordsch
Dschoordsch requested changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@Dschoordsch Dschoordsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, but I don't feel good merging it as is. At the very least we should sanitize it because I don't trust it. People might find a way to sneak html past ChatGPT somehow.

...ient/modules/email/components/SummaryEmail/MeetingSummaryEmail/WholeMeetingSummaryResult.tsx Outdated Show resolved Hide resolved
...ient/modules/email/components/SummaryEmail/MeetingSummaryEmail/WholeMeetingSummaryResult.tsx Outdated Show resolved Hide resolved
...ient/modules/email/components/SummaryEmail/MeetingSummaryEmail/WholeMeetingSummaryResult.tsx Outdated Show resolved Hide resolved
@nickoferrall nickoferrall requested a review from mattkrick August 12, 2024 15:55
@mattkrick
Copy link
Member

look sanitary to me!

@nickoferrall nickoferrall merged commit bf1851e into master Aug 12, 2024
6 checks passed
@nickoferrall nickoferrall deleted the feat/10040/update-meeting-summary-ui branch August 12, 2024 17:43
@parabol-release-bot parabol-release-bot bot mentioned this pull request Aug 12, 2024
Merged
@github-actions github-actions bot mentioned this pull request Aug 12, 2024
Merged
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dschoordsch Dschoordsch Dschoordsch requested changes

@mattkrick mattkrick mattkrick approved these changes

Assignees
No one assigned
Labels
size/s
Projects
Product
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Insights: update meeting summary UI
3 participants
@nickoferrall @mattkrick @Dschoordsch