feat: generate new meeting summaries for a team #10050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickoferrall
commented
Jul 30, 2024
| .filter((row: any) => | ||
| row('meetingType') | ||
| .eq('retrospective') | ||
| .and(row('createdAt').ge(twoYearsAgo)) |
There was a problem hiding this comment.
I have this two year limit so that the mutation doesn't take too long, but we could remove it and just accept that it might take several minutes to complete? Otherwise, when building the Insights UI, we'll need to restrict summaries to the past two years
mattkrick
reviewed
Jul 31, 2024
packages/server/graphql/private/mutations/generateMeetingSummary.ts
Outdated
Show resolved
Hide resolved
| await r | ||
| .table('NewMeeting') | ||
| .get(meeting.id) | ||
| .update({summary: newSummary, updatedAt: now}) |
There was a problem hiding this comment.
+1 overwriting a user-facing value on an ad-hoc basis feels a little dirty. It means the experiments we run will be immediately visible to the user. Probably OK for now if we assume the prompt isn't going to change!
|
Hey @mattkrick, bumping the review request on this one 🙏 |
mattkrick
approved these changes
Aug 6, 2024
|
good to go! let's try it out & see what we learn |
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10038
This PR lets Parabol super admins generate new meeting summaries for a team(s).
This is required to create a summary of summaries (#10017) as the old meeting summaries don't include quotes or links to the meeting.
Once a Parabol super admin generates new meeting summaries for a team, we'll then be able to get a better summary of summaries output.
I suggest reviewing this PR first, and then the parent: #10017
I'll create a follow-up PR that updates the meeting summary UI to handle the markdown links: #10040
I've added a Notion doc here as a guide to generate insights.
To test
cloud-sql-proxy --address 0.0.0.0 --port 5433 parabol-saas-staging:us-central1:saas-staging-postgresql-clone-for-upgradegenerateMeetingSummariesfor a given team and see the updated summaries. For a team with many meetings, it could take 30-60+ seconds to run.