Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Azure auth from a SPA to web app #7114

Closed
2 tasks
nickoferrall opened this issue Aug 25, 2022 · 4 comments
Closed
2 tasks

Change Azure auth from a SPA to web app #7114

nickoferrall opened this issue Aug 25, 2022 · 4 comments
Labels
bug icebox p2 Needs to be addressed on a reasonable timescale

Comments

@nickoferrall
Copy link
Contributor

Our Azure auth is currently set up as a SPA which means that refresh tokens expire after 24hrs and the user needs to manually re-auth, see #7097 (comment)

It looks like we should actually be registered as a web app (see #7097 (comment)) which would give us a more lenient refresh token.

AC

  • Investigate whether we can change our Azure auth from a SPA to a web app
  • If we can, implement the change
@nickoferrall nickoferrall moved this to To Prioritize in Sprint Board Beta Aug 25, 2022
@nickoferrall nickoferrall mentioned this issue Aug 25, 2022
Merged
@mattkrick
Copy link
Member

I'll mark this as P2 for now since this is affects everyone who wants to use this integration.

@jordanh jordanh added p3 Should be addressed when able p2 Needs to be addressed on a reasonable timescale and removed p3 Should be addressed when able labels Aug 30, 2022
@jordanh
Copy link
Contributor

jordanh commented Aug 30, 2022

Done!

@jordanh jordanh moved this from To Prioritize to Backlog in Sprint Board Beta Sep 28, 2022
@mwermuth mwermuth moved this to Backlog in Bugs/Support Oct 7, 2022
@github-actions
Copy link
Contributor

Stale issue

@github-actions github-actions bot added the stale label Feb 27, 2023
@jordanh jordanh added icebox and removed stale labels Feb 28, 2023
@jordanh
Copy link
Contributor

jordanh commented Feb 28, 2023

This is a sad one to icebox. We should definitely do this one. But, our tension isn't so great to take action on it.

@jordanh jordanh closed this as completed Apr 11, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in Sprint Board Beta Apr 11, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in Bugs/Support Apr 11, 2023
@Dschoordsch Dschoordsch mentioned this issue May 3, 2023
Closed
@mattkrick mattkrick mentioned this issue Jul 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug icebox p2 Needs to be addressed on a reasonable timescale
Projects
Bugs/Support
Status: Done
Sprint Board Beta
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jordanh @mattkrick @nickoferrall