Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ZX Spectrum media file icons. #3882

Merged

Conversation

achadwick
Copy link
Contributor

@achadwick achadwick commented Dec 26, 2024

This branch adds icons for the mime types listed here, which are known to Fuse (a Sinclair ZX Spectrum emulator) and a plethora of other Spectrum emulators. The Fuse project is pretty widespread, and their team are actively maintaining the list. Helpfully, they've arranged it so that they all use the application-x-spectrum icon name, so I hope no symlinks will be needed for Papirus. The 35 of 36 types defined in that package work on my screen anyway.

The new icons are fairly obviously patterned after the existing Papirus icons for the Fuse program itself.

16 22 24 32 48 64 (added by this branch)

16 22 24 32 48 64 (existing icons for Fuse)

I hope everything looks OK with these designs. Let me know if you'd like me to adjust anything. Stylistically, I've made the "ZX" scale a bit more than the Fuse icon, and have a more consistent relationship to the stripes. Hope that's OK for now.

Fuse's ZX Spectrum emulation MIME types

All supported with the one icon. Mostly they can hierarchically fall back to the application-x-spectrum name, for the rare app that can do that and actually wants to, but doesn't speak shared-mime-info XML.

  • audio/x-spectrum-csw
  • application/x-spectrum-dck
  • application/x-spectrum-d80
  • application/x-spectrum-dsk
  • application/x-spectrum-fdi
  • application/x-spectrum-hdf
  • application/x-spectrum-img
  • application/x-spectrum-ltp
  • application/x-spectrum-mdr
  • application/x-spectrum-mgt
  • application/x-spectrum-mgtsnp
  • application/x-spectrum-opd
  • application/x-spectrum-opu
  • application/x-spectrum-pzx
  • application/x-spectrum-raw
  • application/x-spectrum-rom
  • application/x-spectrum-rzx
  • application/x-spectrum-sad
  • application/x-spectrum-scl
  • application/x-spectrum-slt
  • application/x-spectrum-sna
  • application/x-spectrum-snp
  • application/x-spectrum-sp
  • application/x-spectrum-spc
  • application/x-spectrum-sta
  • application/x-spectrum-szx
  • application/x-spectrum-td0
  • application/x-spectrum-tap
  • application/x-spectrum-trd
  • application/x-spectrum-tzx
  • application/x-spectrum-udi
  • application/x-spectrum-z80
  • application/x-spectrum-zxs
  • audio/x-spectrum-wav (low priority, just in case you don't have a regular .wav definition (!?). doesn't use the icon)
  • application/x-spectrum-compressed
  • application/x-spectrum-compressed-bz2

Related issue: #2505

As provided by the /usr/share/mime/packages/fuse.xml of Debian's
fuse-emulator-common as of Debian testing (for 13), 2024-12-26.
They all use application-x-spectrum, hopefully no symlinks needed.
The adjoining 45° diagonals of the rainbow stripes over their dark background
was making hairline artefacts with librsvg renderers. The 48K Spectrums didn't
have lines between their stripes, so it may be better to avoid the Fuse and the
derived application-x-spectrum icons having these artefacts.

https://duckduckgo.com/?q=Spectrum+48K&ia=images&iax=images

Layering the stripes with overlap fixes the issue, and makes the inevitable
intermediate pixel a blend without any darkening.

Followup to PapirusDevelopmentTeam#3882.
@achadwick
Copy link
Contributor Author

I noticed an RSVG rendering glitch with these stripes that may or may not be intentional. I've fixed it for the Fuse icons and for these new related mimetypes on a side branch, but I'm not sure whether @Vectrex actually intended this effect back in cb20a13 or not. After all, having a hair-thin dark line between blocks of can make things stand out more.

before, with hairline artefactfixed (maybe), without hairline artefact

Let me know which look you prefer. If everyone agrees, I can merge my 1050282 that gets rid of the artefact to this PR.

@achadwick
Copy link
Contributor Author

For what it's worth, I slightly prefer the one without the dark hairline rendering artefact. I could make the blue a bit darker, to match the photos at https://duckduckgo.com/?q=Spectrum+48K&ia=images&iax=images too.

@achadwick
Copy link
Contributor Author

Merged the nohairline branch. I think it's definitely an improvement.

Mute the colours to be more like the sample palette. Should have more
of a warm and retro feel too.
@achadwick
Copy link
Contributor Author

I muted them a bit, to more closely match the sample palette. I like the warmer tones a bit more, especially alongside the standard colours I'm trying in #3885.

application-x-spectrum@64x64 application-x-spectrum@48x48 application-x-spectrum@32x32 application-x-spectrum@24x24 application-x-spectrum@22x22 application-x-spectrum@16x16

fuse@64x64 fuse@48x48 fuse@32x32 fuse@24x24 fuse@22x22 fuse@16x16

I think that's it for now. OK to merge?

achadwick added a commit to achadwick/papirus-icon-theme that referenced this pull request Dec 29, 2024
@Vectrex
Copy link
Contributor

Vectrex commented Dec 30, 2024

Nice to see that my icons gets some love. I'm not entirely sure what my intentions were back in 2017 but the update looks good.

@achadwick achadwick mentioned this pull request Jan 5, 2025
30 tasks
@achadwick
Copy link
Contributor Author

achadwick commented Jan 13, 2025

I always think that #e4e4e4 is too dim, but that's the standard, apparently. Looks like the docs need updating.

@achadwick
Copy link
Contributor Author

I think that this is ready for merge, with that little change. @morganist?

@achadwick
Copy link
Contributor Author

Actually, I'm less certain about this now. There are loads of icons that use pure #ffffff for white designs on icons, including the generics. I'll just correct that commit (sorry for the noise)

@achadwick achadwick force-pushed the zx-spectrum-mimetypes branch from e081191 to e764920 Compare January 13, 2025 20:23
@morganist morganist merged commit ebec5e5 into PapirusDevelopmentTeam:master Jan 15, 2025
@morganist
Copy link
Contributor

nice work!

@achadwick achadwick deleted the zx-spectrum-mimetypes branch January 15, 2025 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants