-
-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ZX Spectrum media file icons. #3882
Add ZX Spectrum media file icons. #3882
Conversation
As provided by the /usr/share/mime/packages/fuse.xml of Debian's fuse-emulator-common as of Debian testing (for 13), 2024-12-26. They all use application-x-spectrum, hopefully no symlinks needed.
The adjoining 45° diagonals of the rainbow stripes over their dark background was making hairline artefacts with librsvg renderers. The 48K Spectrums didn't have lines between their stripes, so it may be better to avoid the Fuse and the derived application-x-spectrum icons having these artefacts. https://duckduckgo.com/?q=Spectrum+48K&ia=images&iax=images Layering the stripes with overlap fixes the issue, and makes the inevitable intermediate pixel a blend without any darkening. Followup to PapirusDevelopmentTeam#3882.
I noticed an RSVG rendering glitch with these stripes that may or may not be intentional. I've fixed it for the Fuse icons and for these new related mimetypes on a side branch, but I'm not sure whether @Vectrex actually intended this effect back in cb20a13 or not. After all, having a hair-thin dark line between blocks of can make things stand out more. Let me know which look you prefer. If everyone agrees, I can merge my 1050282 that gets rid of the artefact to this PR. |
For what it's worth, I slightly prefer the one without the dark hairline rendering artefact. I could make the blue a bit darker, to match the photos at https://duckduckgo.com/?q=Spectrum+48K&ia=images&iax=images too. |
Merged the nohairline branch. I think it's definitely an improvement. |
Mute the colours to be more like the sample palette. Should have more of a warm and retro feel too.
I muted them a bit, to more closely match the sample palette. I like the warmer tones a bit more, especially alongside the standard colours I'm trying in #3885. I think that's it for now. OK to merge? |
Nice to see that my icons gets some love. I'm not entirely sure what my intentions were back in 2017 but the update looks good. |
I always think that |
I think that this is ready for merge, with that little change. @morganist? |
Actually, I'm less certain about this now. There are loads of icons that use pure |
e081191
to
e764920
Compare
nice work! |
This branch adds icons for the mime types listed here, which are known to Fuse (a Sinclair ZX Spectrum emulator) and a plethora of other Spectrum emulators. The Fuse project is pretty widespread, and their team are actively maintaining the list. Helpfully, they've arranged it so that they all use the
application-x-spectrum
icon name, so I hope no symlinks will be needed for Papirus. The 35 of 36 types defined in that package work on my screen anyway.The new icons are fairly obviously patterned after the existing Papirus icons for the Fuse program itself.
(added by this branch)
(existing icons for Fuse)
I hope everything looks OK with these designs. Let me know if you'd like me to adjust anything. Stylistically, I've made the "ZX" scale a bit more than the Fuse icon, and have a more consistent relationship to the stripes. Hope that's OK for now.
Fuse's ZX Spectrum emulation MIME types
All supported with the one icon. Mostly they can hierarchically fall back to the
application-x-spectrum
name, for the rare app that can do that and actually wants to, but doesn't speak shared-mime-info XML.audio/x-spectrum-wav(low priority, just in case you don't have a regular .wav definition (!?). doesn't use the icon)Related issue: #2505