-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compression level change with config option #9711
Conversation
You can generally add a coauthor by simply adding their name into the patch, see e.g. https://github.com/PaperMC/Paper/blob/master/patches/server/0872-Fix-a-bunch-of-vanilla-bugs.patch#L60 |
the placement of the option is ok or should I move that as well? |
yea 👍 imo it is. |
@Leguan16 good job ;), it'd be nice if paper added on the docs examples of the available compression options with example of rates, as a benchmark of course, this should benefit a few servers a lot with bandwidth decreasing as well as more performance and cost decreasing :) |
This does require a PR to the docs before it may be merged yea. @Leguan16 if you have the time, it would be great if you can propose the change there as well 👍 |
I can add a description to the |
I don't see the usage for benchmarking on the docs. A quick explanation that a higher compression level means more CPU time spend for less data transmitted and a lower value meaning less CPU time spend but more data transmitted is fine. |
Alright! I will add that later. |
I opened a PR in the docs repo |
Docs is ready to go 😄 |
d0457d9
to
cc62992
Compare
Supersedes #9703
As from the author requested: Here a new version with the correct patches and a config option.
The config option is located under the
misc
section. I did not know if I should change the version of the config but that should not stop this PR from being merged.Is it possible to add people as co-authors so the original author also gets credits?