Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sign update desync #9695

Closed
wants to merge 1 commit into from
Closed

Fix sign update desync #9695

wants to merge 1 commit into from

Conversation

ScriptLineStudios
Copy link

Stops desync (most likely caused by latency) in the event of a player updating a block which the server hasn't recognized as a sign.

@ScriptLineStudios ScriptLineStudios requested a review from a team as a code owner September 9, 2023 14:27
@Warriorrrr
Copy link
Member

Do you have any link to a place this issue you're fixing has been reported at and/or reproduction instructions? As it stands, this PR has a few issues which makes it not mergable:

  • Sending a block entity update packet doesn't do anything in terms of desync
  • This will cause an NPE if there is no block entity where the client thinks there is one
  • There is no range check done

@Owen1212055
Copy link
Member

Closing this as in general it's not really certain what you are trying to fix here. Feel free to respond with a more detailed description of your changes, but it's not really understood what kind of "desync" this is resolving here.

@ScriptLineStudios ScriptLineStudios deleted the Fix-sign-update-desync branch October 29, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

3 participants