Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce sign line nullability when setting line with Adventure Method #9689

Merged
merged 3 commits into from
Sep 16, 2023
Merged

Enforce sign line nullability when setting line with Adventure Method #9689

merged 3 commits into from
Sep 16, 2023

Conversation

thelooter
Copy link
Contributor

Enforces the nullability when setting a Sign Line with the Adventure Method

@thelooter thelooter requested a review from a team as a code owner September 7, 2023 20:43
Leguan16
Leguan16 reviewed Sep 7, 2023
View reviewed changes
Machine-Maker
Machine-Maker approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@Machine-Maker Machine-Maker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of the API uses checkArgument so the exception is of the IllegalArgumentException type instead of NPE, but idk how big a deal that is.

@lynxplay lynxplay force-pushed the feat/enforce_sign_line_nullability branch from febab28 to 49c9e11 Compare September 16, 2023 21:13
@lynxplay lynxplay merged commit 0c8e84c into PaperMC:master Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Leguan16 Leguan16 Leguan16 left review comments

@electronicboy electronicboy electronicboy approved these changes

@Machine-Maker Machine-Maker Machine-Maker approved these changes

@Warriorrrr Warriorrrr Warriorrrr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Paper PR Queue
Status: Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@thelooter @electronicboy @Machine-Maker @Warriorrrr @Leguan16 @lynxplay