Add additional tags to ItemMeta obfuscation filtering #9665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Filtering custom model data is a no go |
Owen1212055
previously requested changes
Aug 28, 2023
|
That's why I deliberately put it inside the |
|
visual effects are generally more trivial things, idk how a lode compass appears differently to others if it has a pos or not, but, CMD is purely intended to allow people to change how items look in general using datapacks, etc; it being removed ever sounds like a stupidly niche edge-case at best |
Sytm
force-pushed
the
more-item-meta-obfuscation
branch
from
de15d58
to
707fcc7
Compare
NoahvdAa
reviewed
Aug 29, 2023
| @@ -107,6 +111,8 @@ index a5cf00a41c61cc9f851781cc4f55c9bb47c2f5b6..f306c9e8f46d80d4c4fdc671e3754b3f | |||
| + // the position and fake the dimension | |||
| + tag.putString("LodestoneDimension", "paper:paper"); | |||
| + } | |||
| + // The id of a filled map | |||
| + tag.remove("map"); | |||
There was a problem hiding this comment.
What changes visually when this tag is missing?
There was a problem hiding this comment.
Vanilla does not have any visual changes, but some mods which aren't necessarily cheats could behave differently.
Sytm
force-pushed
the
more-item-meta-obfuscation
branch
from
707fcc7
to
b186b4e
Compare
Machine-Maker
approved these changes
Oct 14, 2023
lynxplay
force-pushed
the
more-item-meta-obfuscation
branch
from
b186b4e
to
d212bba
Compare
lynxplay
approved these changes
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9451
(Is blacklist filtering even feasible like Machine said in the linked issue or would it be too much work to cover all edge cases?)