Fix javac api compile errors (experimental branch) #9630
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe upstream fixed it with this commit (and the bukkit counterpart) |
I tried it out, by implementing these specific upstream changes into the experimental branch api, between your comment and writing this comment and saw that is fixed by this upstream commit like written in your comment. Sorry for opening the pull request... I never worked with wildcards and generics and because of that I didn't saw the connection between the upstream commit and the compiler errors... (I didn't create the patch only for this pull request. I made it to fix the experimental branch so that I can continue my experimenting...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope this pull request is welcome...
This PR fixes compile errors related to the javac compiler in the experimental branch until upstream fixes it (if they do).
All the code changes were successfully tested.
Before/After this PR gets merged an upstream update would be great because md_5 updated the experimental branch two days ago.