Add EntityExtinguishEvent #9610
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bug fixes should definitely go in a separate patch, not in the implementation of an event. |
Warriorrrr
force-pushed
the
feat/entity-extinguish-event
branch
3 times, most recently
from
affa6b0
to
19705b1
Compare
Warriorrrr
force-pushed
the
feat/entity-extinguish-event
branch
from
19705b1
to
ec5f57b
Compare
|
Thanks, addressed the comments and fixed one additional vanilla bug |
kennytv
reviewed
Aug 23, 2023
Warriorrrr
force-pushed
the
feat/entity-extinguish-event
branch
from
ec5f57b
to
9fe8a1f
Compare
Warriorrrr
force-pushed
the
feat/entity-extinguish-event
branch
from
9fe8a1f
to
e3d618d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5143, continuation of #5242
Also fixes two vanilla bugs related to extinguishing