Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clicked position to PlayerUseUnknownEntityEvent #9604

Merged
merged 5 commits into from
Aug 16, 2023
Merged

Conversation

kennytv
Copy link
Member

@kennytv kennytv commented Aug 14, 2023

Fixes the event being called 4 times (2 per hand) when a player right clicks with no difference to the event data. Also adds some javadoc and removes an unnecessary access transformer

@kennytv kennytv requested a review from a team as a code owner August 14, 2023 07:11
Copy link
Member

@NoahvdAa NoahvdAa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from the fact that it doesn't compile

patches/server/0009-MC-Utils.patch Outdated Show resolved Hide resolved
@kennytv
Copy link
Member Author

kennytv commented Aug 14, 2023

Shhh

@Cryptite
Copy link
Contributor

Cryptite commented Aug 15, 2023

This isn't exactly the right place for this comment, probably, but is there some way in which this event could either be cancelled, or toggled as "consumed" in such a way where interacting with an unknown entity stops all subsequent future actions? Examples are:

  • Right-clicking a packet NPC holding a consumable both interacts with it, but also you start eating.
  • Same thing but when holding projectiles (pearls, potions, etc)

Or maybe there's another way people have been handling this.

@kennytv
Copy link
Member Author

kennytv commented Aug 15, 2023

It'd be best if you created an issue for that

@kennytv kennytv merged commit 73af2d4 into master Aug 16, 2023
2 checks passed
@kennytv kennytv deleted the useunknownentity branch August 16, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants