Improve performance of mass crafts #9603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytv
added
the
build-pr-jar
kennytv
approved these changes
Aug 21, 2023
Machine-Maker
force-pushed
the
fix/shift-click-craft-perf
branch
from
07a91a2 to
0f31d07
Compare
kennytv
force-pushed
the
fix/shift-click-craft-perf
branch
from
0f31d07 to
2d52866
Compare
Machine-Maker
force-pushed
the
fix/shift-click-craft-perf
branch
from
2d52866 to
be54532
Compare
kennytv
force-pushed
the
fix/shift-click-craft-perf
branch
from
be54532 to
928cfc9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See patch description for a breakdown of this.
To test the performance implications I used spark's profiler and tickmonitor both set to report ticks over 55ms. Doing 3 mass crafts without this patch resulted in this. With this patch, none of the crafts tripped the tickmonitor or profiler.
There are probably further improvements done. Like the
slotChangedCraftingGridstatic method in CraftingMenu is called 576 times to re-calculate the recipe for a full 9 stack shift-click craft. This calls thePrepareItemCraftEvent576 times and sends that many packets setting the result slot content.Download the paperclip jar for this pull request: paper-9603.zip