-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Mushroom spread configuration to world config #9592
Conversation
…mBlock randomTick method
The lists are only supposed to contain ticks for the 1 radius neighbours of the chunk.
patches/server/1000-Increase-vanilla-mushroom-spread-limit.patch
Outdated
Show resolved
Hide resolved
Yeah, I think in this case an IntOr.DefaultOrDisabled would be nice. I, by far, prefer using words instead of random constants. You never know what might change in the future. Like plenty of I can implement that type if you'd like. Otherwise, just look at how the other ones are implemented and adapt it |
This comment was marked as resolved.
This comment was marked as resolved.
Co-authored-by: Jake Potrebic <[email protected]> Co-authored-by: Bjarne Koll <[email protected]>
Effect or LevelEvent needs to be replaced but ideally after the enum PR has been merged upstream. Until then, this test and these fixes should address all the known issues with them
- int i = 5; | ||
+ // Paper start - Increase vanilla mushroom spread | ||
+ int mushroomSpreadLimit = world.paperConfig().environment.mushroom.spreadLimit.or(5); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving the original i = 5 and using the i as the default in the .or might look a bit cleaner, but generally looks pretty good.
…er into feat/mushroom-spread-config # Conflicts: # patches/server/0005-Paper-config-files.patch
I created a new PR with all new changes from Paper/master for better lisibility & workflow on my side. |
This update introduces a mushroom configuration to the Paper world, providing users with the ability to bypass the standard vanilla spread limit. This customization allows users to exert more control over mushroom spreading, potentially leading to increased mushroom growth within the designated area.