Increase vanilla mushroom spread limit #9591
Conversation
| + | ||
| + public Mushroom mushroom; | ||
| + | ||
| + public class Mushroom extends ConfigurationPart { |
There was a problem hiding this comment.
New configuration options should be added to the paper configuration patch, not the patch consuming the config option.
There was a problem hiding this comment.
Do you mean I should do a patch with the config, & then another patch that will use it ?
There was a problem hiding this comment.
The diff in question here should live in the https://github.com/PaperMC/Paper/blob/master/patches/server/0005-Paper-config-files.patch patch.
| + public Mushroom mushroom; | ||
| + | ||
| + public class Mushroom extends ConfigurationPart { | ||
| + public int spreadLimit = 5; |
There was a problem hiding this comment.
I think IntOr.Default would fit a lot better here.
| + if(mushroomSpreadLimit == -1) { | ||
| + mushroomSpreadLimit = 9 * 9 * 3; // Paper - 9x9x3 Vanilla SHAPE sum | ||
| + } | ||
| + int i = mushroomSpreadLimit; |
There was a problem hiding this comment.
Why is the definition of i moved below the iterator and flag creation ? This just seems like added diff for no reason.
| @@ -0,0 +1,46 @@ | |||
| From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 | |||
| From: =?UTF-8?q?L=C3=A9o=20Moriceau?= <[email protected]> | |||
There was a problem hiding this comment.
Are you sure this is the correct name of the author ?
This update introduces a mushroom configuration to the Paper world, providing users with the ability to bypass the standard vanilla spread limit. This customization allows users to exert more control over mushroom spreading, potentially leading to increased mushroom growth within the designated area.