Add-Mob-Spawner-support-to-AffectsSpawning #9578
Conversation
| }; | ||
| + | ||
| + public static final Predicate<Entity> PLAYER_AFFECTS_MOB_SPAWNER_SPAWNING = (entity) -> { | ||
| + return !entity.isSpectator() && entity.isAlive() && entity instanceof Player player && player.affectsSpawning; |
There was a problem hiding this comment.
If I see this correctly you want to do this?
| + return !entity.isSpectator() && entity.isAlive() && entity instanceof Player player && player.affectsSpawning; | |
| + return !entity.isSpectator() && entity.isAlive() && entity instanceof Player player && player.affectsMobSpawnersSpawning; |
There was a problem hiding this comment.
Kind of? I want to make it only impact Natural Spawns and not spawns from Spawners themself.
| - public void setAffectsSpawning(boolean affects) { | ||
| + public void setAffectsSpawning(boolean affects, boolean affectsMobSpawners) { | ||
| this.getHandle().affectsSpawning = affects; | ||
| + this.getHandle().affectsMobSpawnersSpawning = affectsMobSpawners; | ||
| } |
There was a problem hiding this comment.
At the moment this would be an API break.
There was a problem hiding this comment.
So I guess I would have to seperate this and make it seperately with a new set and get for this. I got stuck towards the section of src/main/java/net/minecraft/world/entity/Mob where you can't look at both. What I could do is seperate both so they are different but then again, this might also break API for those who use the method to get rid of all spawns which I want to prevent as well.
There was a problem hiding this comment.
I believe I have changed this, however, I am unable to figure out how to change the section listed (CheckDespawn) and SkeletonTrapGoals "canUse" section as it seems pre hardcoded in and I'm not too sure how to change this.
|
|
||
| // Paper start - optimise checkDespawn | ||
| public final List<ServerPlayer> playersAffectingSpawning = new java.util.ArrayList<>(); | ||
| + public final List<ServerPlayer> playersAffectingNaturalSpawning = new java.util.ArrayList<>(); |
There was a problem hiding this comment.
Thanks! Will resolve this.
There was a problem hiding this comment.
This should be resolved.
Oops I must've had it on the wrong directory, my bad. EDIT: I think I've put it back but it attached to Whitelist Events API??? Not sure why it's done that. |
Not sure why the API attached to the whitelist events???
|
I am going to close this as I don't think a secondary check here is really the way to go. An alternative approach that I could see working in the future would be an event called before the spawner searches for nearby players. To counterbalance the performance impact, this event might also allow for the definition of a backoff cooldown from even searching for players (while still running the rest of the tick logic). This would I hope you can understand my points here, if you have further questions, we are always around on our discord :) |
Introduce API for Mob Spawner support for AffectsSpawning to allow different type of spawning types. The reason for this as it would allow for the ability to only prevent natural spawns and keep mob spawns from spawners.
Originally I was just going to create another get/set, however, the code for checkDespawn is quite hard to change without breaking a previous patch hence I opted for editing original API by adding an extra boolean to the get (public void setAffectsSpawning(boolean affects, boolean affectsMobSpawners))
I believe everything should work by common sense but unsure if I've missed or possibly stuffed something up as it's my first time meddling around with this.