-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix secure profile with proxy online mode #9256
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like the code here is from an earlier state of the branch since #9183 (review) applies again.
Oh, sorry, that's my fault. |
Finally, rebased the code |
bump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be nice to put this behind a config option so that it isn't immediately enabled, proxies and chat signing is still a bit iffy
public boolean enforceSecureProfile() { | ||
- return this.getProperties().enforceSecureProfile && this.getProperties().onlineMode; | ||
+ // Paper start - fix secure profile with proxy online mode | ||
+ var globalConfiguration = io.papermc.paper.configuration.GlobalConfiguration.get(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This globalConfiguration variable isn't needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would you name the config entry for this?
And I am using this for a few months now and have no problems at all behind my velocity proxy (and without) and the chat is working as it should even with a custom chat format and (when modified) with modified messages.
Failed to check out the right branch... again... |
This pr is same as the last one in #9183
I messed up with the commit, so i made this one