Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix secure profile with proxy online mode #9256

Closed
wants to merge 5 commits into from
Closed

fix secure profile with proxy online mode #9256

wants to merge 5 commits into from

Conversation

NonSwag
Copy link
Contributor

@NonSwag NonSwag commented Jun 3, 2023

This pr is same as the last one in #9183
I messed up with the commit, so i made this one

@NonSwag NonSwag requested a review from a team as a code owner June 3, 2023 19:57
Copy link
Member

@Warriorrrr Warriorrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the code here is from an earlier state of the branch since #9183 (review) applies again.

@NonSwag
Copy link
Contributor Author

NonSwag commented Jun 4, 2023

Oh, sorry, that's my fault.
I forgot to check the commit.

@NonSwag
Copy link
Contributor Author

NonSwag commented Jul 14, 2023

Finally, rebased the code
totally forgot about this pr sorry

@NonSwag NonSwag requested a review from Warriorrrr July 18, 2023 14:02
@NonSwag
Copy link
Contributor Author

NonSwag commented Aug 13, 2023

bump

Copy link
Member

@Warriorrrr Warriorrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be nice to put this behind a config option so that it isn't immediately enabled, proxies and chat signing is still a bit iffy

public boolean enforceSecureProfile() {
- return this.getProperties().enforceSecureProfile && this.getProperties().onlineMode;
+ // Paper start - fix secure profile with proxy online mode
+ var globalConfiguration = io.papermc.paper.configuration.GlobalConfiguration.get();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This globalConfiguration variable isn't needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would you name the config entry for this?
And I am using this for a few months now and have no problems at all behind my velocity proxy (and without) and the chat is working as it should even with a custom chat format and (when modified) with modified messages.

@NonSwag
Copy link
Contributor Author

NonSwag commented Sep 10, 2023

Failed to check out the right branch... again...
I'll close this and move it to a new pr... again...

@NonSwag NonSwag closed this Sep 10, 2023
@NonSwag NonSwag deleted the secure-profile-fix branch September 10, 2023 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

2 participants