Fix getMaxHeight to be exclusive instead of inclusive to match docs #11675
+20
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getMaxHeightdocs says that the value is exclusive, not inclusive. This has changed in 1.21.3 and since 1.21.3 the value is now inclusive due to Mojang changes. This patch changes the value to be exclusive by +1 the returned value from NMS.Worth nothing that this needs to be tested! I haven't tested it yet, and I seen that there are some CraftBukkit code that does call
getMaxHeight(setBiome)Fixes #11674