Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove string dupe exploit setting #11670

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Leguan16
Copy link
Contributor

Removes the unused config option that enabled string duping.

@Leguan16 Leguan16 requested a review from a team as a code owner November 26, 2024 18:50
@Leguan16 Leguan16 force-pushed the remove-string-dupe-exploit-setting branch from c27e1a9 to f992cbf Compare November 26, 2024 19:03
@electronicboy
Copy link
Member

This also needs to be added into the thing to remove old keys, I think?

@lynxplay
Copy link
Contributor

And a follow up docs PR 👍

@Leguan16
Copy link
Contributor Author

And a follow up docs PR 👍

I know I just wanted to wait until I have confirmation that it's actually obsolete. I will open the PR shortly.

@Leguan16 Leguan16 force-pushed the remove-string-dupe-exploit-setting branch from f992cbf to d26a387 Compare November 26, 2024 19:19
@electronicboy
Copy link
Member

Yes, it's obsolete as mojang fixed this themselves

@Leguan16
Copy link
Contributor Author

I think everything should be good to go now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Awaiting review
Development

Successfully merging this pull request may close these issues.

3 participants